Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multicast socket #999

Merged
merged 1 commit into from
Jun 10, 2016
Merged

multicast socket #999

merged 1 commit into from
Jun 10, 2016

Conversation

m-mcgowan
Copy link
Contributor

@m-mcgowan m-mcgowan commented May 15, 2016 •
edited
Loading

Adds an additional parameter to the socket multicast methods to allow the actual socket to be passed since this may be needed by some implementations (e.g. gcc.)

Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device
  • Add documentation
  • MDM: not going to add to changelog since it's an internal interface change.

@m-mcgowan
Adds an additional parameter to the socket multicast methods to allow…
7f465b0 
… the actual socket to be passed since this may be needed by some implementations (e.g. gcc.)
@m-mcgowan m-mcgowan added this to the 0.6.x milestone Jun 8, 2016
@sergeuz
Copy link
Member

sergeuz commented Jun 10, 2016 •
edited
Loading

The code looks good. I made a simple multicast client application and it runs normally on gcc platform.

@m-mcgowan m-mcgowan merged commit 0fd5f9d into develop Jun 10, 2016
@m-mcgowan m-mcgowan deleted the feature/multicast-socket branch September 27, 2016 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.x
Development

Successfully merging this pull request may close these issues.
2 participants
@m-mcgowan @sergeuz