-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for event content types #2804
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monkbroc
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great from my point of view. No additional feedback at this point.
sergeuz
force-pushed
the
typed-publish/sc-129495
branch
from
August 9, 2024 09:02
14875e5
to
0825a6a
Compare
sergeuz
force-pushed
the
typed-publish/sc-129495
branch
from
August 20, 2024 12:06
0825a6a
to
ca470ea
Compare
sergeuz
force-pushed
the
typed-publish/sc-129495
branch
from
September 18, 2024 14:41
ca470ea
to
c2cd5aa
Compare
avtolstoy
approved these changes
Sep 20, 2024
…nly accepts text data
sergeuz
force-pushed
the
typed-publish/sc-129495
branch
from
September 20, 2024 13:53
81479be
to
47f82c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the
Particle.publish()
andParticle.subscribe()
APIs to support events with non-plain text data. The actual format of the data is determined by its content type:This PR also includes the changes from #2815.
Example
Publishing binary data:
Subscribing to binary events:
When publishing/subscribing to events with a content type via the HTTP API, the event data is expected to be encoded as a data URI.
References