Fix communication loop errors when handling ACKs for Describe messages #2756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eberseth
approved these changes
Mar 12, 2024
avtolstoy
approved these changes
Mar 13, 2024
…andled by some other subsystem
avtolstoy
force-pushed
the
fix/blockwise_describe_handling
branch
from
f357fb6
to
ad0f061
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When handling a CoAP ACK for a Describe or OTAv3 message, the protocol implementation still forwards the message to the new CoAP implementation which causes an error if the code that handled the ACK in the first place happened to overwrite the contents of the shared message buffer.
Solution
Stop further processing of the ACK message if it was handled by one of the aforementioned subsystems.
Steps to Test
Run the
communication/*tests.