Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor WiFi credential check; [Gen 4] WiFi thread safety issues, USB re-enumeration bugfix for weird USB hubs #2754

Merged
merged 8 commits into from
Mar 14, 2024

Conversation

XuGuohui
Copy link
Member

Problem

  1. Device will save invalid credentials if there is valid crdentials with other SSID present
  2. BLE provisioning breaks due to the Wi-Fi disconnection after setting credentials

Solution

  1. Validate credentials before saving
  2. Add a flag to not disconnect Wi-Fi connection after validating the credentials

Steps to Test

  1. tests/wiring/wifi_cred_check
  2. Go through BLE provisioning process

References

N/A


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@XuGuohui XuGuohui force-pushed the fix/rtl872x-saving-wrong-credentials branch from 44b1336 to d905e47 Compare March 12, 2024 13:36
@XuGuohui XuGuohui added this to the 5.8.0 milestone Mar 12, 2024
@XuGuohui
Copy link
Member Author

@avtolstoy @jlovinger-particle This PR is ready for review now.

@avtolstoy avtolstoy force-pushed the fix/rtl872x-saving-wrong-credentials branch from c68e5a2 to c8ebd95 Compare March 13, 2024 21:12
@avtolstoy avtolstoy changed the title Refactor WiFi credential check. Refactor WiFi credential check; [Gen 4] WiFi thread safety issues, USB re-enumeration bugfix for weird USB hubs Mar 14, 2024
@avtolstoy avtolstoy merged commit fdcc93f into develop Mar 14, 2024
13 checks passed
@avtolstoy avtolstoy deleted the fix/rtl872x-saving-wrong-credentials branch March 14, 2024 08:11
@Kategrode
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants