-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance ICCID control request to Include IMEI and ICCID #2730
Conversation
@@ -357,6 +357,10 @@ void SystemControl::processRequest(ctrl_request* req, ControlRequestChannel* /* | |||
setResult(req, ctrl::wifi::scanNetworks(req)); | |||
break; | |||
} | |||
case CTRL_REQUEST_WIFI_MAC_ADDRESS: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This request should not really be necessary. MAC addresses are available since introduction of CTRL_REQUEST_NETWORK_GET_INTERFACE_LIST
and CTRL_REQUEST_NETWORK_GET_INTERFACE
: https://github.com/particle-iot/device-os-protobuf/blob/main/control/network.proto#L94
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add a new request to get a 'base MAC' and size of the allocation per device, but it's not going to be wifi-specific, it's more of a device identifier-like data similar to serial/device id/mobile secret etc.
For Gen 4 devices the size of the allocation is 4 for example:
0 - WiFi STA
1 - WiFi AP
2 - BLE
3 - Ethernet
WiFi-specific MAC should be picked from interface data and should be available since Device OS 3.x.
c6199bb
to
30e1ec0
Compare
c04583d
to
74cb5ff
Compare
74cb5ff
to
74701dc
Compare
74701dc
to
9e4dd2d
Compare
9e4dd2d
to
bf929ae
Compare
Hi @avtolstoy This PR is ready to be merged. Pinging you here in case you would like to take a look before I merge it in. TY! Hope this can make it to 5.8.0 |
Description
This branch / PR adds IMEI to the response of the ICCID control request
Steps to Test
particle-cli
branch with the testing instructions : Feature/replace serial cmds particle-cli#713particle-cli
repo, runnpm start -- serial mac
on wifi device, ornpm start -- serial identify
from cellular deviceExample App
References
Particle-CLI : particle-iot/particle-cli#713
Particle-USB : particle-iot/device-os-protobuf#26
Device-os-protobuf: particle-iot/device-os-protobuf#26
Completeness