[rtl872x] Use security type from usb message for joining hidden networks #2724
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Joining a hidden wifi network via USB
JoinNewNetworkRequest
message fails even if the fields are populated correctly, iehidden
is true, andsecurity
is set to the correct value.Solution
P2 platforms will use the provided SSID to scan for the network, and infer the security type from the actual network. I believe this was done to workaround CLI/app issues when P2 platform was being brought up.
If the network is not found, or it is hidden, then no security value will be used and any wifi connection attempts will fail.
The solution is to use the provided
security
type from the USB message if the network is hidden, or is not detected during a scan.Steps to Test
output:
Example App
Any
References
Original hidden network support PR
Completeness