Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[acm] Fix Network.preferred() -> Network.prefer() #2717

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

scott-brust
Copy link
Member

Problem

  1. Network.preferred() is less clear than simply Cellular.prefer()
  2. Network.preferred() will both set the desired network back to default, and then return Network instead of the actual preferred network reference.

Solution

  1. Network.preferred() renamed to be clearer ie: WiFi.prefer(true)
  2. Network.prefer() will not reset the default network. The supported ways to clear any network preference are:
    a) Network.prefer(false) and b) explicitly calling .prefer(false) with the preferred interface, ie WiFi.prefer(false)

Steps to Test

Use connection-manager test application, item 2

Example App

connection-manager

References

ACM MVP API


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@scott-brust scott-brust merged commit ae9348c into develop Dec 14, 2023
13 checks passed
@scott-brust scott-brust deleted the fix/acm-network-preferred branch December 14, 2023 18:15
@scott-brust scott-brust added this to the 5.6.1 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants