-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/sc-77462/project-commands #2543
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… commands from: ``` prtcl compile:all source:/path/to/device-os argon /path/to/tinker --quiet ``` to: ``` prtcl project:compile /path/to/tinker --toolchain source:/path/to/device-os argon --platform argon --task all --quiet ```
busticated
force-pushed
the
feature/sc-77462/project-commands
branch
2 times, most recently
from
September 28, 2022 17:26
f741ff9
to
9d6e22b
Compare
I ran this locally with the latest
Does |
yes, see here and here. the |
scott-brust
approved these changes
Sep 28, 2022
scott-brust
pushed a commit
that referenced
this pull request
Oct 12, 2022
…ommands feature/sc-77462/project-commands
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
prtcl
CLI now includes support forproject
-related build commands. The currentcompile
,flash
, andclean
commands will be deprecated and removedSolution
Move the
test-build-system
CI workflow over to the newproject:compile
andproject:clean
commandsSteps to Test
prtcl
CLI (instructions)cd /path/to/device-os
./ci/test-build-tasks.sh ./
prtcl
CLI (instructions)cd /path/to/device-os
./ci/test-build-tasks.sh ./
prtcl
CLI (instructions)cd C:\\path\to\device-os
.\ci\test-build-tasks.ps1 .\
outcome
Scripts should run properly - exiting on error and otherwise reporting success. CI configuration changes should make sense and do what you expect.
References
https://app.shortcut.com/particle/story/77462
Completeness