[rtl872x] usb: make sure CDC line coding struct is packed #2541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott-brust
force-pushed
the
fix/p2-usb-cdc-linecoding
branch
from
19e6731
to
8071930
Compare
scott-brust
approved these changes
Sep 28, 2022
scott-brust
force-pushed
the
fix/p2-usb-cdc-linecoding
branch
from
8071930
to
c864ef9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
USB linecoding struct is supposed to be 7 bytes only, due to default packing configuration compiler aligns it to 8 bytes currently, which causes SET_LINE_CODING requests to fail.
Example App
N/A
References
Completeness