Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rtl872x] adds Tracker M in release.sh for prebootloader build #2522

Merged
merged 1 commit into from
Aug 19, 2022
Merged

[rtl872x] adds Tracker M in release.sh for prebootloader build #2522

merged 1 commit into from
Aug 19, 2022

Conversation

technobly
Copy link
Member

Problem

Tracker M prebootloader binaries are not included in the combined-binaries zip file.

Solution

Add Tracker M to release.sh for the prebootloader build.

Steps to Test

  • Build in CircleCI
  • Check combined-binaries workflow artifacts for correct files in zip

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@technobly technobly added this to the 5.0.0 milestone Aug 19, 2022
@technobly technobly marked this pull request as ready for review August 19, 2022 05:37
@technobly technobly merged commit c9b2b0e into develop Aug 19, 2022
@technobly technobly deleted the fix/release-script-trackerm branch August 19, 2022 05:47
@technobly technobly mentioned this pull request Aug 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuGuohui XuGuohui XuGuohui approved these changes

@avtolstoy avtolstoy Awaiting requested review from avtolstoy

@keeramis keeramis Awaiting requested review from keeramis

@scott-brust scott-brust Awaiting requested review from scott-brust

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@technobly @XuGuohui