Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] [gen3] fixes interrupts() API, should not clear pending interrupts #2504

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

technobly
Copy link
Member

Problem

  • [gen3] interrupts() API should not clear pending interrupts

Solution

  • [gen3] pending interrupts was being cleared unintentionally. Simply removing the clearPending call resolves it.

Steps to Test

  • run TEST=app/interrupts on all platforms, jumpering a wire from A5 to D0 ~ D6 one at a time and resetting the device between tests.

References

Changelog

BUGFIXES

  • [gen3] fixes interrupts() API, should not clear pending interrupts

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@technobly technobly added the bug label Aug 11, 2022
@technobly technobly added this to the 4.0.0 milestone Aug 11, 2022
@avtolstoy avtolstoy changed the title [gen3] fixes interrupts() API, should not clear pending interrupts [4.x] [gen3] fixes interrupts() API, should not clear pending interrupts Aug 11, 2022
@technobly technobly merged commit f4011f5 into develop-4.x Aug 12, 2022
@technobly technobly deleted the fix/sc-107555-interrupts-4.x branch August 12, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants