Fix compilation errors on Linux

.gitmodules

@@ -45,9 +45,6 @@
 [submodule "third_party/catch2/catch2"]
 	path = third_party/catch2/catch2
 	url = https://github.com/particle-iot/Catch2.git
-	branch = particle
 [submodule "third_party/fakeit/fakeit"]
 	path = third_party/fakeit/fakeit
 	url = https://github.com/particle-iot/Fakeit.git
-	branch = particle
-

build/gcc-tools.mk

@@ -14,7 +14,7 @@ endif
 
 # C compiler flags
 CFLAGS +=  -g3 -m64 -O$(GCC_OPTIMIZE) -gdwarf-2
-CFLAGS += -Wno-unused-local-typedefs
+CFLAGS += -Wno-unused-local-typedefs -Wno-pragmas
 ASFLAGS +=  -g3
 
 

ci/install_boost.sh

@@ -1,10 +1,10 @@
-BOOST_VERSION=1_72_0
+BOOST_VERSION=1_78_0
 
 export BOOST_ROOT=$HOME/.ci/boost/boost_$BOOST_VERSION
 export BOOST_LIBRARYDIR=$BOOST_ROOT/stage/lib
 mkdir -p $BOOST_ROOT
 test -d $BOOST_ROOT || ( echo "boost root $BOOST_ROOT not created." && exit 1)
-test -f $BOOST_ROOT/INSTALL || wget --quiet https://s3.amazonaws.com/spark-assets/boost_${BOOST_VERSION}.tar.gz -O - | tar -xz -C $BOOST_ROOT --strip-components 1
+test -f $BOOST_ROOT/INSTALL || wget --quiet https://spark-assets.s3.amazonaws.com/boost_${BOOST_VERSION}.tar.gz -O - | tar -xz -C $BOOST_ROOT --strip-components 1
 
 if [[ $OSTYPE == darwin* ]]; then
   export DYLD_LIBRARY_PATH="${BOOST_LIBRARYDIR}:$DYLD_LIBRARY_PATH"

communication/src/subscriptions.h

@@ -185,8 +185,11 @@ class Subscriptions
 				{
 					if (event_handlers[i].handler_data)
 					{
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wcast-function-type"
 						EventHandlerWithData handler =
 								(EventHandlerWithData) event_handlers[i].handler;
+#pragma GCC diagnostic pop
 						handler(event_handlers[i].handler_data,
 								(char *) event_name, (char *) data);
 					}

hal/src/gcc/ota_flash_hal.cpp

@@ -121,7 +121,7 @@ void parseServerAddressData(ServerAddress* server_addr, uint8_t* buf)
         *p = 0;
         break;
       }
-      // else fall through to default
+      // else fall through
 
     default:
       server_addr->addr_type = INVALID_INTERNET_ADDRESS;

services/src/rgbled.c

@@ -11,6 +11,9 @@
 #include "rgbled_hal.h"
 #include "module_info.h"
 
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wcast-function-type"
+
 LedCallbacks LED_Callbacks = {
     .version = 0x0000,
     .Led_Rgb_Set_Values = (void(*)(uint16_t r, uint16_t g, uint16_t b, void*))Set_RGB_LED_Values,
@@ -22,6 +25,8 @@ LedCallbacks LED_Callbacks = {
 #endif // MODULE_FUNCTION != MOD_FUNC_BOOTLOADER
 };
 
+#pragma GCC diagnostic pop
+
 volatile uint8_t led_rgb_brightness = DEFAULT_LED_RGB_BRIGHTNESS;
 
 volatile uint8_t LED_RGB_OVERRIDE = 0;

system/src/system_cloud_internal.cpp

@@ -428,7 +428,10 @@ void invokeEventHandlerInternal(uint16_t handlerInfoSize, FilteringEventHandler*
 {
     if(handlerInfo->handler_data)
     {
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wcast-function-type"
         EventHandlerWithData handler = (EventHandlerWithData) handlerInfo->handler;
+#pragma GCC diagnostic pop
         handler(handlerInfo->handler_data, event_name, data);
     }
     else

test/unit_tests/communication/util/coap_message.cpp

@@ -57,7 +57,7 @@ unsigned CoapMessageOption::decodeUInt(const std::string& data) {
 std::string CoapMessage::encode() const {
     std::string buf;
     for (;;) {
-        CoapMessageEncoder e(&buf.front(), buf.size());
+        CoapMessageEncoder e(buf.empty() ? nullptr : &buf.front(), buf.size());
         e.type(type());
         e.code(code());
         e.id(id());

third_party/mbedtls/build.mk

@@ -2,3 +2,5 @@ TARGET_MBEDTLS_SRC_PATH = $(MBEDTLS_MODULE_PATH)/mbedtls/library
 
 # C source files included in this build.
 CSRC += $(call target_files,$(TARGET_MBEDTLS_SRC_PATH)/,*.c)
+
+CFLAGS += -Wno-array-parameter

wiring/inc/spark_wiring_cloud.h

@@ -443,7 +443,10 @@ class CloudClass {
         {
             auto wrapper = new wiring_event_handler_t(handler);
             if (wrapper) {
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wcast-function-type"
                 success = spark_subscribe(eventName, (EventHandler)call_wiring_event_handler, wrapper, scope, deviceID, NULL);
+#pragma GCC diagnostic pop
             }
         }
         return success;

wiring/inc/spark_wiring_system.h

@@ -528,11 +528,17 @@ class SystemClass {
 
     // TODO: system_unsubscribe_event() isn't implemented yet.
     static void off(void(*handler)(system_event_t, int, void*)) {
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wcast-function-type"
         system_unsubscribe_event(all_events, reinterpret_cast<system_event_handler_t*>(handler), nullptr);
+#pragma GCC diagnostic pop
     }
 
     static void off(system_event_t events, void(*handler)(system_event_t, int, void*)) {
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wcast-function-type"
         system_unsubscribe_event(events, reinterpret_cast<system_event_handler_t*>(handler), nullptr);
+#pragma GCC diagnostic pop
     }