Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wiring] acquireSerialXBuffer() support #2375

Merged
merged 3 commits into from
Nov 5, 2021
Merged

[wiring] acquireSerialXBuffer() support #2375

merged 3 commits into from
Nov 5, 2021

Conversation

avtolstoy
Copy link
Member

Problem

The default 64-byte USART RX/TX buffer may not be sufficient for some applications.

Solution

  1. Introduce API similar to https://docs.particle.io/cards/firmware/serial/acquireserialbuffer/ or https://docs.particle.io/cards/firmware/wire-i2c/acquirewirebuffer/ for USARTs
  2. Introduce hal_usart_init_ex() support for Gen 2

Steps to Test

  • wiring/serial_loopback
  • wiring/serial_loopback2

Build tests with default settings and with USE_BUFFER_SIZE=256 for example.

Example App

N/A

References

N/A

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@avtolstoy avtolstoy added this to the 3.2.0 milestone Nov 4, 2021
keeramis
keeramis approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@keeramis keeramis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran on-device tests on Electron and Boron, and they passed.

@avtolstoy avtolstoy merged commit 317fb88 into develop Nov 5, 2021
@avtolstoy avtolstoy deleted the feature/wiring-acquire-serialx-buffer branch November 5, 2021 23:21
@avtolstoy avtolstoy restored the feature/wiring-acquire-serialx-buffer branch November 5, 2021 23:26
@avtolstoy avtolstoy deleted the feature/wiring-acquire-serialx-buffer branch November 5, 2021 23:29
avtolstoy added a commit that referenced this pull request Nov 5, 2021
@avtolstoy
Merge pull request #2375 from particle-iot/feature/wiring-acquire-ser…
bb957f8 
…ialx-buffer

[wiring] acquireSerialXBuffer() support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keeramis keeramis keeramis approved these changes

@XuGuohui XuGuohui XuGuohui approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@avtolstoy @XuGuohui @keeramis