Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase particle connection timeout to 9 min for on-device tests where applicable #2369

Merged
merged 6 commits into from
Nov 5, 2021

Conversation

keeramis
Copy link
Contributor

Problem

On-device tests fail at Particle.connect() in certain locations as network coverage varies

Solution

Increase the connection timeout to 9 min where applicable.

Steps to Test

Run device-os-test-runner

References

See concourse logs for failed test cases


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

Copy link
Member

@avtolstoy avtolstoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 As a quick solution. More generally we should probably add some define easily accessible everywhere (e.g. in hal_platform_config.h ?)

@keeramis keeramis force-pushed the feature/increase-conn-timeout-for-tests branch from 212d40b to eedcc56 Compare November 1, 2021 20:49
@keeramis
Copy link
Contributor Author

keeramis commented Nov 2, 2021

I have noticed that in some cases that even connecting back from Particle.disconnect() was taking longer than expected - for example, this build and src code.
This is probably because it's 2G.

@keeramis
Copy link
Contributor Author

keeramis commented Nov 2, 2021

@avtolstoy Set a HAL_PLATFORM_CELLULAR_CONN_TIMEOUT value in hal_platform.h

@keeramis keeramis force-pushed the feature/increase-conn-timeout-for-tests branch from 3f53763 to eedcc56 Compare November 3, 2021 14:02
@avtolstoy avtolstoy force-pushed the feature/increase-conn-timeout-for-tests branch from 7ac8a0d to bd29b41 Compare November 5, 2021 23:35
@avtolstoy avtolstoy merged commit 6c17b3a into develop Nov 5, 2021
@avtolstoy avtolstoy deleted the feature/increase-conn-timeout-for-tests branch November 5, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants