[boron|bsom] u-blox R510 support

hal/inc/cellular_hal.h

@@ -262,6 +262,11 @@ cellular_result_t cellular_get_active_sim(int* sim_type, void* reserved);
  */
 cellular_result_t cellular_process(void* reserved, void* reserved1);
 
+/**
+ * Start NCP FW Update
+ */
+int cellular_start_ncp_firmware_update(bool update = false, void* reserved = NULL);
+
 #ifdef __cplusplus
 }
 #endif

hal/network/lwip/ppp_client.cpp

@@ -88,8 +88,11 @@ void Client::init() {
     netif_set_client_data(&if_, netifClientDataIdx_, this);
     UNLOCK_TCPIP_CORE();
 
+    // FIXME: do we need this workaround for R510?
     // XXX:
-    if (platform_primary_ncp_identifier() == PLATFORM_NCP_SARA_R410) {
+    if (platform_primary_ncp_identifier() == PLATFORM_NCP_SARA_R410 ||
+        platform_primary_ncp_identifier() == PLATFORM_NCP_SARA_R510)
+        {
       // SARA R4 PPP implementation is broken and often times we receive
       // an empty or non-conflicting Configure-Request in an already opened state
       // which, if we follow the state machine to the T, should restart the negotiation

hal/network/ncp/cellular/cellular_hal.cpp

@@ -33,6 +33,7 @@
 #include "at_command.h"
 #include "at_response.h"
 #include "cellular_enums_hal.h"
+#include "cellular_ncp_dev_mapping.h"
 
 #include <limits>
 
@@ -193,32 +194,7 @@ int cellular_device_info(CellularDevice* info, void* reserved) {
     CHECK(client->getIccid(info->iccid, sizeof(info->iccid)));
     CHECK(client->getImei(info->imei, sizeof(info->imei)));
     if (info->size >= offsetof(CellularDevice, dev) + sizeof(CellularDevice::dev)) {
-        switch (client->ncpId()) {
-        case PLATFORM_NCP_SARA_U201:
-            info->dev = DEV_SARA_U201;
-            break;
-        case PLATFORM_NCP_SARA_G350:
-            info->dev = DEV_SARA_G350;
-            break;
-        case PLATFORM_NCP_SARA_R410:
-            info->dev = DEV_SARA_R410;
-            break;
-        case PLATFORM_NCP_QUECTEL_BG96:
-            info->dev = DEV_QUECTEL_BG96;
-            break;
-        case PLATFORM_NCP_QUECTEL_EG91_E:
-            info->dev = DEV_QUECTEL_EG91_E;
-            break;
-        case PLATFORM_NCP_QUECTEL_EG91_NA:
-            info->dev = DEV_QUECTEL_EG91_NA;
-            break;
-        case PLATFORM_NCP_QUECTEL_EG91_EX:
-            info->dev = DEV_QUECTEL_EG91_EX;
-            break;
-        default:
-            info->dev = DEV_UNKNOWN;
-            break;
-        }
+        info->dev = cellular_dev_from_ncp((PlatformNCPIdentifier)client->ncpId());
     }
     if (info->size >= offsetof(CellularDevice, radiofw) + sizeof(CellularDevice::radiofw)) {
         CHECK(client->getFirmwareVersionString(info->radiofw, sizeof(info->radiofw)));
@@ -623,3 +599,12 @@ int cellular_get_active_sim(int* simType, void* reserved) {
     }
     return 0;
 }
+
+int cellular_start_ncp_firmware_update(bool update, void* reserved) {
+    const auto mgr = cellularNetworkManager();
+    CHECK_TRUE(mgr, SYSTEM_ERROR_UNKNOWN);
+    const auto client = mgr->ncpClient();
+    CHECK_TRUE(client, SYSTEM_ERROR_UNKNOWN);
+    CHECK(client->startNcpFwUpdate(update));
+    return SYSTEM_ERROR_NONE;
+}

hal/network/ncp/cellular/cellular_ncp_client.h

@@ -132,6 +132,7 @@ class CellularNcpClient: public NcpClient {
     virtual int enterDataMode() = 0;
     virtual int getMtu() = 0;
     virtual int urcs(bool enable) = 0;
+    virtual int startNcpFwUpdate(bool update) = 0;
 };
 
 inline CellularNcpClientConfig::CellularNcpClientConfig() :

hal/network/ncp_client/quectel/quectel_ncp_client.cpp

@@ -337,6 +337,7 @@ int QuectelNcpClient::on() {
         return SYSTEM_ERROR_NONE;
     }
     // Power on the modem
+    LOG(TRACE, "Powering modem on, ncpId: 0x%02x", ncpId());
     auto r = modemPowerOn();
     if (r != SYSTEM_ERROR_NONE && r != SYSTEM_ERROR_ALREADY_EXISTS) {
         return r;
@@ -1531,6 +1532,10 @@ int QuectelNcpClient::urcs(bool enable) {
     return SYSTEM_ERROR_NONE;
 }
 
+int QuectelNcpClient::startNcpFwUpdate(bool update) {
+    return 0;
+}
+
 void QuectelNcpClient::connectionState(NcpConnectionState state) {
     if (ncpState_ == NcpState::DISABLED) {
         return;
@@ -1816,7 +1821,6 @@ int QuectelNcpClient::modemPowerOn() {
     if (!modemPowerState()) {
         ncpPowerState(NcpPowerState::TRANSIENT_ON);
 
-        LOG(TRACE, "Powering modem on");
         // Power on, power on pulse >= 100ms
         // NOTE: The BGPWR pin is inverted
         HAL_GPIO_Write(BGPWR, 1);

hal/network/ncp_client/quectel/quectel_ncp_client.h

@@ -73,6 +73,7 @@ class QuectelNcpClient: public CellularNcpClient {
     virtual int enterDataMode() override;
     virtual int getMtu() override;
     virtual int urcs(bool enable) override;
+    virtual int startNcpFwUpdate(bool update) override;
 
     auto getMuxer() {
         return &muxer_;