Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-device tests for #2335 #2337

Merged
merged 7 commits into from
Jul 12, 2021
Merged

On-device tests for #2335 #2337

merged 7 commits into from
Jul 12, 2021

Conversation

avtolstoy
Copy link
Member

Problem

See #2335

Solution

This PR:

  1. Adds CLOUD_04_socket_errors_do_not_cause_a_full_handshake test to wiring/no_fixture test suite to simulate socket errors by closing the cloud socket and validating that cloud connection is re-established without performing a full handshake
  2. Adds CLOUD_05_loss_of_cellular_network_connectivity_does_not_cause_full_handshake test to wiring/no_fixture test suite to simulate socket errors due to low signal/cellular network conditions by causing a cellular network disconnect and checking that cloud connection is re-established without performing a full handshake
  3. To facilitate above tests two new cloud_status system event types were added: cloud_status_session_resume and cloud_status_handshake.
  4. To facilitate CLOUD_04_socket_errors_do_not_cause_a_full_handshake system_internal() was extended to provide cloud socket id.

This PR also fixes a bug in NETWORK_01_LargePacketsDontCauseIssues_ResolveMtu.

Steps to Test

Run CLOUD_* tests in wiring/no_fixture suite.

Example App

N/A

References


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

handshakeState.reset();
System.on(cloud_status, evHandler);
SCOPE_GUARD({
System.off(cloud_status, evHandler);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that unsubscribing from system events is not implemented 😅

…f_cellular_network_connectivity_does_not_cause_full_handshak
…ixture_stress as no_fixture overflows on Electron with test runner framework enabled
@avtolstoy
Copy link
Member Author

Added some final fixes for R410-based devices and re-ran on all devices: ✔️ passed

@avtolstoy avtolstoy merged commit 51983d4 into develop Jul 12, 2021
@avtolstoy avtolstoy deleted the socket_errors_test/ch82443 branch July 12, 2021 18:45
@keeramis keeramis mentioned this pull request Jul 19, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants