-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On-device tests for #2335 #2337
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e events and system_cloud_get_socket_handle() + system_internal()
…argePacketsDontCauseIssues_ResolveMtu
…ctivity_does_not_cause_full_handshake, minor fixes
technobly
approved these changes
Jul 9, 2021
sergeuz
approved these changes
Jul 12, 2021
handshakeState.reset(); | ||
System.on(cloud_status, evHandler); | ||
SCOPE_GUARD({ | ||
System.off(cloud_status, evHandler); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that unsubscribing from system events is not implemented 😅
…f_cellular_network_connectivity_does_not_cause_full_handshak
…ixture_stress as no_fixture overflows on Electron with test runner framework enabled
Added some final fixes for R410-based devices and re-ran on all devices: ✔️ passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #2335
Solution
This PR:
CLOUD_04_socket_errors_do_not_cause_a_full_handshake
test towiring/no_fixture
test suite to simulate socket errors by closing the cloud socket and validating that cloud connection is re-established without performing a full handshakeCLOUD_05_loss_of_cellular_network_connectivity_does_not_cause_full_handshake
test towiring/no_fixture
test suite to simulate socket errors due to low signal/cellular network conditions by causing a cellular network disconnect and checking that cloud connection is re-established without performing a full handshakecloud_status
system event types were added:cloud_status_session_resume
andcloud_status_handshake
.CLOUD_04_socket_errors_do_not_cause_a_full_handshake
system_internal()
was extended to provide cloud socket id.This PR also fixes a bug in
NETWORK_01_LargePacketsDontCauseIssues_ResolveMtu
.Steps to Test
Run
CLOUD_*
tests inwiring/no_fixture
suite.Example App
N/A
References
Completeness