Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gen2] Add cellular registration intervention commands to Gen2 #2301

Merged
merged 5 commits into from
Mar 25, 2021

Conversation

keeramis
Copy link
Contributor

@keeramis keeramis commented Mar 22, 2021

Problem

Add cellular AT intervention commands to Gen2, to improve/speed up registration process. This is particularly helpful in scenarios where the radio struggles to connect to an invalid operator.

Solution

  1. Added CellularRegistrationStatusMdm similar to the one in Gen3 to run intervention commands
  2. Replaced the csd, psd, and eps members of NetStatus with CellularRegistrationStatusMdm's status methods for consistency.

Steps to Test

Run any tinker-like app on Gen3 which enables connecting to the network. Try removing the antenna or using an invalid SIM, even better if there are known network issues in a given area to check how the the intervention commands run and help register to a network.

Example App

void setup() {
}

void loop() {
}

References


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

Copy link
Member

@avtolstoy avtolstoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, rejecting only to remove code duplication with CellularRegistrationStatusMdm.

Double check AT+CGATT vs AT+CGACT.

hal/src/electron/modem/mdm_hal.cpp Outdated Show resolved Hide resolved
hal/src/electron/modem/mdm_hal.cpp Outdated Show resolved Hide resolved
hal/src/electron/modem/mdm_hal.cpp Outdated Show resolved Hide resolved
hal/src/electron/modem/mdm_hal.cpp Outdated Show resolved Hide resolved
hal/src/electron/modem/mdm_hal.h Outdated Show resolved Hide resolved
@keeramis keeramis requested a review from avtolstoy March 22, 2021 21:41
hal/shared/cellular_enums_hal.h Show resolved Hide resolved
hal/shared/cellular_reg_status.h Outdated Show resolved Hide resolved
hal/src/electron/modem/mdm_hal.h Outdated Show resolved Hide resolved
@keeramis keeramis merged commit a2e8e25 into develop Mar 25, 2021
@keeramis keeramis deleted the gen2_intervention_cmds branch March 25, 2021 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants