Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default assignment for SPI chip select #2275

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

eberseth
Copy link
Contributor

@eberseth eberseth commented Feb 4, 2021

Problem

The SPI interface default chip select state is set to SPI_DEFAULT_SS which may override user defined pin map controls over GPIO pins. Normally the user will assign and manage their own chip select and not use the native SS pin from the MCU peripheral.

Solution

Replace references to the default MCU peripheral chip select pin, SS, with an invalid pin map entry, PIN_INVALID so that the user can specify GPIO.

Steps to Test

N/A

Example App

N/A

References

N/A


Completeness

  • User is totes amazing for contributing!
  • [x ] Contributor has signed CLA (Info here)
  • [x ] Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@eberseth eberseth added the bug label Feb 4, 2021
@eberseth eberseth added this to the 3.0.0 milestone Feb 5, 2021
@eberseth eberseth force-pushed the fix/default-spi-cs-pin/ch71972 branch from 29c9541 to c66ce46 Compare February 11, 2021 17:54
@eberseth eberseth merged commit d677aea into develop Feb 11, 2021
@eberseth eberseth deleted the fix/default-spi-cs-pin/ch71972 branch February 11, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants