Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wiring] BLE: return false if expected characteristic is not found. #2266

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

XuGuohui
Copy link
Member

Problem

getCharacteristicByDescription() return true even if there is no characteristic is matched.

Solution

return false if there is no characteristic matches the given description.

Example App

N/A

References

N/A

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@XuGuohui XuGuohui added bug needs review ble Bluetooth Low Energy labels Jan 15, 2021
@XuGuohui XuGuohui added this to the 2.0.2 milestone Jan 15, 2021
@XuGuohui XuGuohui added ready to merge PR has been reviewed and tested and removed needs review labels Jan 18, 2021
@XuGuohui XuGuohui merged commit f10774b into develop Jan 18, 2021
@XuGuohui XuGuohui deleted the fix/ble/ch71263 branch January 18, 2021 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ble Bluetooth Low Energy bug ready to merge PR has been reviewed and tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants