Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLE: supports LESC pairing. #2262

Merged
merged 9 commits into from
Mar 10, 2021
Merged

BLE: supports LESC pairing. #2262

merged 9 commits into from
Mar 10, 2021

Conversation

XuGuohui
Copy link
Member

@XuGuohui XuGuohui commented Dec 28, 2020 •
edited
Loading

As the title describes.

References

BLE core spec 5.0, Vol.3, Part H, Section 2.3.5.6.

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@XuGuohui XuGuohui added in progress feature ble Bluetooth Low Energy labels Dec 28, 2020
@XuGuohui XuGuohui added this to the 3.0.0 milestone Dec 28, 2020
avtolstoy
avtolstoy requested changes Jan 19, 2021
View reviewed changes
hal/inc/ble_hal.h Outdated Show resolved Hide resolved
hal/src/nRF52840/ble_hal.cpp Outdated Show resolved Hide resolved
hal/src/nRF52840/ble_hal.cpp Outdated Show resolved Hide resolved
hal/src/nRF52840/ble_hal.cpp Outdated Show resolved Hide resolved
hal/src/nRF52840/ble_hal.cpp Outdated Show resolved Hide resolved
hal/inc/ble_hal.h Outdated Show resolved Hide resolved
hal/src/nRF52840/ble_hal.cpp Outdated Show resolved Hide resolved
hal/src/nRF52840/ble_hal.cpp Outdated Show resolved Hide resolved
hal/src/nRF52840/ble_hal.cpp Outdated Show resolved Hide resolved
hal/src/nRF52840/ble_hal.cpp Show resolved Hide resolved
@avtolstoy
Copy link
Member

Good job 🎉

avtolstoy
avtolstoy requested changes Feb 1, 2021
View reviewed changes
hal/src/nRF52840/ble_hal.cpp Show resolved Hide resolved
hal/src/nRF52840/ble_hal.cpp Outdated Show resolved Hide resolved
@avtolstoy avtolstoy modified the milestones: 3.0.0, 3.1.0 Feb 16, 2021
avtolstoy
avtolstoy approved these changes Feb 24, 2021
View reviewed changes
hal/src/nRF52840/ble_hal.cpp Show resolved Hide resolved
hal/inc/ble_hal.h Show resolved Hide resolved
hal/inc/ble_hal.h Outdated Show resolved Hide resolved
avtolstoy
avtolstoy approved these changes Feb 24, 2021
View reviewed changes
hal/inc/ble_hal.h Outdated Show resolved Hide resolved
@XuGuohui XuGuohui added ready to merge PR has been reviewed and tested and removed DO NOT MERGE labels Mar 10, 2021
@XuGuohui XuGuohui merged commit 024e7f3 into develop Mar 10, 2021
@XuGuohui XuGuohui deleted the feature/ble_lesc/ch69992 branch March 10, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgolu mgolu mgolu approved these changes

@avtolstoy avtolstoy avtolstoy approved these changes

Assignees
No one assigned
Labels
ble Bluetooth Low Energy feature ready to merge PR has been reviewed and tested
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@XuGuohui @avtolstoy @mgolu