Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gen2] usart: fix D0 AF unconditionally being changed in hal_usart_end() #2256

Merged
merged 2 commits into from
Dec 21, 2020

Conversation

avtolstoy
Copy link
Member

@avtolstoy avtolstoy commented Dec 18, 2020

Problem

Wire.begin();
Serial1.begin(115200);
Serial1.end();

The following code will leave I2C peripheral in a non-functioning state on Gen 2 platforms, because D0 Alternate-Function will be reset to default value unconditionally by a call to Serial1.end().

Steps to Test

  • wiring/no_fixture UART* tests

Example App

N/A

References

  • [CH70258]
  • [CH70277]

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@avtolstoy avtolstoy added the bug label Dec 18, 2020
@avtolstoy avtolstoy added this to the 2.0.2 milestone Dec 18, 2020
@avtolstoy avtolstoy merged commit 923d48c into develop Dec 21, 2020
@avtolstoy avtolstoy deleted the fix/gen2-serial1-wire-d0-flow-control branch December 21, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants