BLE: supports legacy pairing. #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgolu
reviewed
Nov 23, 2020
mgolu
reviewed
Nov 25, 2020
mgolu
reviewed
Dec 1, 2020
There was a problem hiding this comment.
This looks really good.
I did the following integration testing with Boron as a Central device, and BLE devices that require pairing:
- nRF evaluation board with Nordic firmware that makes it a peripheral that requires pairing: passed
- Masterbuilt meat smoker that requires passkey authentication: passed
- Omron Blood Pressure monitor: failed. Upon further investigation, it uses LESC, not Legacy Pairing, so pairing to this device is not in scope of this PR.
XuGuohui
commented
Dec 12, 2020
XuGuohui
commented
Dec 12, 2020
mgolu
approved these changes
Dec 18, 2020
mgolu
approved these changes
Dec 21, 2020
avtolstoy
approved these changes
Dec 22, 2020
hal/src/nRF52840/ble_hal_impl.h
Outdated
| @@ -121,6 +121,8 @@ | |||
| #define BLE_MAX_PERIPHERAL_COUNT NRF_SDH_BLE_PERIPHERAL_LINK_COUNT | |||
| #define BLE_MAX_CENTRAL_COUNT NRF_SDH_BLE_CENTRAL_LINK_COUNT | |||
|
|
|||
| #define BLE_PAIRING_PASSKEY_LEN 6 | |||
There was a problem hiding this comment.
Nit: move to ble_hal_defines.h perhaps? I believe this is a universal BLE constant.
| } hal_ble_pairing_passkey_input_evt_t; | ||
|
|
||
| typedef struct hal_ble_pairing_status_updated_evt_t { | ||
| int status; |
There was a problem hiding this comment.
The SoftDevice features uint8_t for the authentication status and the status here will also indicate system error, so I think int is sufficient and is consistent with the function that returns system error.
hal/src/nRF52840/ble_hal.cpp
Outdated
Comment on lines
1902
to
1907
| secParams.min_key_size = 7; | ||
| secParams.max_key_size = 16; | ||
| secParams.kdist_own.enc = 1; | ||
| secParams.kdist_own.id = 1; | ||
| secParams.kdist_peer.enc = 1; | ||
| secParams.kdist_peer.id = 1; |
There was a problem hiding this comment.
For the one bit-filed member, I'll just use true/false instead.
hal/src/nRF52840/ble_hal.cpp
Outdated
Comment on lines
2333
to
2338
| secParams.min_key_size = 7; | ||
| secParams.max_key_size = 16; | ||
| secParams.kdist_own.enc = 1; | ||
| secParams.kdist_own.id = 1; | ||
| secParams.kdist_peer.enc = 1; | ||
| secParams.kdist_peer.id = 1; |
XuGuohui
force-pushed
the
feature/ble_passkey/ch50363
branch
from
48523f5
to
fd950b8
Compare
avtolstoy
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title describes.
Example App
References
N/A
Completeness