Fixes the issue that BLE.scan() might hang the device. #2220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
BLE may hang the thread that calls
BLE.scan()
due to unexpected scanning failure. Since theBLE.scan()
is a blocking API waiting until a semaphore is given on scanning timeout event, in some condition the scanning procedure never timeout or a incorrect event is delivered from SoftDevice on scanning failure, in which case the semaphore cannot be taken any more.Solution
Introduce a timer to guard the scanning procedure. For example, if the scanning timeout is set to 5s and it starts scanning, the timer will expire after 6s to stop scanning actively. Normally BLE scanning can timeout by SoftDevice and the timer will be stopped by then.
References
#1932
Completeness