Disconnect from the cloud before going to sleep #2206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avtolstoy
approved these changes
Oct 2, 2020
| @@ -29,8 +29,6 @@ | |||
|
|
|||
| void Spark_Signal(bool on, unsigned, void*); | |||
| void Spark_SetTime(unsigned long dateTime); | |||
| void Spark_Sleep(unsigned duration); | |||
| // on the disconnection options that can be set via Particle.setDisconnectOptions() or | ||
| // Particle.disconnect(). | ||
| // | ||
| // TODO: Rename CLOUD_DISCONNECT_GRACEFULLY to CLOUD_DISCONNECT_IMMEDIATELY and invert its |
…work interfaces is used as a wakeup source
avtolstoy
force-pushed
the
sleep_disconnect/ch64208
branch
from
ade9783
to
63626c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
By default, the Sleep 2.0 API leaves the protocol layer in whatever state it was before going to sleep and continues to use it after waking up from sleep without checking whether the session with the server is still valid.
Solution
Always disconnect from the cloud before going to sleep unless the network interface is used as a wake-up source. In the latter case, send a PING message to the server after waking up from sleep.
Steps to Test
References