Update mbedTLS to 2.22.0 #2117
Merged
Update mbedTLS to 2.22.0 #2117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avtolstoy
requested changes
Jun 23, 2020
There was a problem hiding this comment.
Requesting changes only because of:
✔️ / 🔴 Reviewed MbedTLS changes. NULL check needs to be added in Mbed-TLS/mbedtls@mbedtls-2.22.0...particle-iot:particle-2.22.0#diff-cd6cf1fb8879a22b47bde81311b6947cR999
✔️ Devices running this branch should connect to the cloud normally (TCP and UDP)
✔️ UDP devices should be able to resume their sessions
✔️ Photon should be able to connect to a WPA Enterprise network (PEAP/MSCHAPv2 and EAP-TLS verified. Requires #2126)
✔️ Device setup via BLE should work correctly.
sergeuz
force-pushed
the
mbedtls-2.22.0/ch55085
branch
from
2fb5ebf
to
b496676
Compare
I force-pushed the change to keep the number of commits small and updated the submodule refs: |
avtolstoy
approved these changes
Jun 23, 2020
avtolstoy
added
ready to merge
sergeuz
force-pushed
the
mbedtls-2.22.0/ch55085
branch
from
b496676
to
5c23de5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR updates mbedTLS from 2.16.2 to 2.22.0. The submodule has been updated to point to the tip of this branch: https://github.com/particle-iot/mbedtls/tree/particle-2.22.0.
For reference, below are diffs of our patchset applied to the upstream mbedTLS 2.16.2 and 2.22.0 releases respectively:
Steps to Test
References