Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/daemon modal #70

Merged
merged 4 commits into from
Aug 10, 2017
Merged

Feature/daemon modal #70

merged 4 commits into from
Aug 10, 2017

Conversation

pciavald
Copy link
Contributor

@pciavald pciavald commented Aug 9, 2017

No description provided.

pciavald
pciavald commented Aug 9, 2017
View reviewed changes
src/app/core/rpc/rpc.module.ts
@@ -21,8 +21,7 @@ export class RpcModule {
RPCService,
PeerService,
PassphraseService,
BlockStatusService,
ElectronService
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appeared twice

pciavald
pciavald commented Aug 9, 2017
View reviewed changes
src/app/core/rpc/rpc.service.ts
@@ -127,8 +154,14 @@ export class RPCService {
* @returns void
*/

register(instance: Injectable, method: string, params: Array<any> | Function | null,
successCB: Function, when: string, errorCB?: Function): void {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readability

pciavald
pciavald commented Aug 9, 2017
View reviewed changes
src/app/core/rpc/rpc.service.ts
@@ -68,7 +79,13 @@ export class RPCService {
* @returns void
*/

call(instance: Injectable, method: string, params: Array<any> | null, successCB: Function, errorCB?: Function): void {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readability

pciavald
pciavald commented Aug 9, 2017
View reviewed changes
src/app/core/rpc/rpc.service.ts
},
error => {
if (errorCB) {
errorCB.call(instance, (typeof error['_body'] === 'object' ? error['_body'] : JSON.parse(error['_body'])) )
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readability

pciavald
pciavald commented Aug 9, 2017
View reviewed changes
src/app/modals/modals.service.ts
@@ -71,7 +82,9 @@ export class ModalsService {

needToOpenModal(status: any) {
// Open syncing Modal
if (!this.isOpen && (status.networkBH <= 0 || status.internalBH <= 0 || status.networkBH - status.internalBH > 50)) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readability

@pciavald
Copy link
Contributor Author

pciavald commented Aug 9, 2017

travis fails because of a bug in angular-cli : angular/angular-cli#7296

@rynomster
Copy link
Member

rynomster commented Aug 10, 2017 •
edited
Loading

Could we get the lint fixed? :D

   src/app/modals/daemon/daemon.component.html
      L1 |<div style="text-align: center;">
              ^ Inline style [  style="text-align: center;" ] cannot be use. (inline-style-disabled)
Scanned 28 files, found 1 errors in 1 files (113 ms)

@pciavald
Copy link
Contributor Author

pciavald commented Aug 10, 2017 via email

@rynomster rynomster merged commit 38f2eb5 into particl:master Aug 10, 2017
kewde
kewde reviewed Aug 11, 2017
View reviewed changes
src/app/modals/daemon/daemon.component.ts
public message: any;

constructor(
@Inject(forwardRef(() => ModalsService)) private _modalsService: ModalsService
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems unused? triggering moved to the model.service

@pciavald pciavald deleted the feature/daemonModal branch December 22, 2017 23:41
zaSmilingIdiot added a commit that referenced this pull request Feb 28, 2022
@zaSmilingIdiot
Merge pull request #70 from zaSmilingIdiot/workaround/ReportComponent…
211dd8d 
…ErrorNotification

Adds an additional check to the item flag response for error handling responses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kewde kewde kewde left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pciavald @rynomster @kewde