Added chalk for pretty output colors #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The
Maybe just stick to white/red/bold. |
parshap
reviewed
Nov 29, 2017
| console.log("Error: Wanted " + name + " version " + raw + " (" + range +")"); | ||
| console.log(PROGRAMS[name].getInstallInstructions(raw)); | ||
| console.error(chalk.red.bold("Error: Wanted " + name + " version " + raw + " (" + range +")")); | ||
| console.log(chalk.red.bold(PROGRAMS[name].getInstallInstructions(raw))); |
There was a problem hiding this comment.
Maybe just the error message should be red and the installation instructions could be normal color? Or are you thinking more red to grab attention?
There was a problem hiding this comment.
I was thinking more red to grab attention. Otherwise it felt like "info" text along with the rest of the display.
There was a problem hiding this comment.
Sounds good to me! Thanks for adding this.
|
Looks good now!
|
|
Published as v3.1.0. |
|
This looks really nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #18.
Might want to be verified by someone on a *nix machine that it isn't atrocious there... but it's through chalk so I doubt it.