feat: hot tier for pmeta #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitisht
requested changes
Aug 11, 2024
server/src/hottier.rs
Outdated
| && !self.check_stream_hot_tier_exists(INTERNAL_STREAM_NAME) | ||
| { | ||
| let mut stream_hot_tier = StreamHotTier { | ||
| size: "10485760".to_string(), |
There was a problem hiding this comment.
Can you make it a constant and refer it here? Same for available_size
nikhilsinhaparseable
force-pushed
the
hot-tier-pmeta
branch
from
0f16454
to
d645fbd
Compare
allow enabling hot tier for the internal stream with a size of 10 MiB only if hot tier is configured globally
nikhilsinhaparseable
force-pushed
the
hot-tier-pmeta
branch
from
d645fbd
to
086bd8a
Compare
nitisht
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow enabling hot tier for the internal stream
with a size of 10 MiB
only if hot tier is configured globally