Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exact match when deleting stream #68

Merged
merged 1 commit into from
Aug 27, 2022
Merged

Conversation

trueleo
Copy link
Contributor

@trueleo trueleo commented Aug 27, 2022

Description

When deleting a logstream from s3 avoid deleting other prefixes which starts with same stream_name for which delete request was made.

For example, when deleting stream named test, such streams are also deleted because they share same prefix test
teststream
testlongrun
testapplication

Fix:
Use delimiter at the end of stream name so that only those prefix are matched where stream name is exactly first component of path on s3. i.e test/ instead of test. This will match only logstreams named test.


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht nitisht merged commit 7fe14b7 into parseablehq:main Aug 27, 2022
@trueleo trueleo deleted the delete_fix branch August 27, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants