Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When deleting a logstream from s3 avoid deleting other prefixes which starts with same stream_name for which delete request was made.
For example, when deleting stream named
test
, such streams are also deleted because they share same prefixtest
test
streamtest
longruntest
applicationFix:
Use delimiter at the end of stream name so that only those prefix are matched where stream name is exactly first component of path on s3. i.e
test/
instead oftest
. This will match only logstreams named test.This PR has: