New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore empty alerts #59

Merged

nitisht merged 1 commit into parseablehq:main from trueleo:ignore_empty_alerts

Aug 24, 2022

Contributor

trueleo commented Aug 24, 2022

Description

Ignore unset alerts on stream when loading from s3. This PR fixes this by using unwrap_or_default on result instead of early return

This PR has:

been tested to ensure log ingestion and log query works.
added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
added documentation for new or modified features or behaviors.


          Ignore empty alerts

a27fdbe

trueleo requested a review from nitisht

August 24, 2022 16:04

nitisht approved these changes

View reviewed changes

nitisht merged commit 28e8884 into parseablehq:main

trueleo deleted the ignore_empty_alerts branch

August 24, 2022 16:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet