Introduce a new error type for ObjectStorage api #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueleo
commented
Aug 18, 2022
nitisht
reviewed
Aug 18, 2022
trueleo
commented
Aug 18, 2022
| _ => continue, | ||
| let metadata = LogStreamMetadata { | ||
| schema: schema.unwrap_or_default(), | ||
| alert_config: alert_config.unwrap_or_default(), |
There was a problem hiding this comment.
Instead of returning or not adding metadata to stream we set it to empty string for now. This allows first event to not fail in case parseable was restarted just after adding a stream.
This behaviour could be changed later by using Option type in LogStreamMetadata.
nitisht
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42.
Description
Create a separate error type for all the methods defined by
ObjectStorage. ThisObjectStorageErrorshould contain those failure variants over which we want to handle error in future.AwsSdkErrorandSdkErrorin AWS S3 crate covers all the variants for failure when calling S3 APIs but parseable needs to have its own Error type that can be used for error handling in the application itself.Added
ObjectStorageErrortype which contains some variants through which we can tell what went wrong when using any of trait methods on S3 object. Though the error variants need to expand in future so that more complex cases could be handled correctlyThis PR has: