Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix granularity subtraction #41

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Fix granularity subtraction #41

merged 1 commit into from
Aug 17, 2022

Conversation

trueleo
Copy link
Contributor

@trueleo trueleo commented Aug 16, 2022 •
edited
Loading

Fixes #40.

Description

This PR fixes time subtraction when adjusting for OBJECT_STORE_DATA_GRANULARITY. By letting chrono subtract minutes from StorageSync time we can ensure right date and time for file URI

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@trueleo trueleo marked this pull request as ready for review August 16, 2022 17:34
@nitisht nitisht merged commit 4945757 into parseablehq:main Aug 17, 2022
@trueleo trueleo deleted the chrono_fix branch August 17, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitisht nitisht nitisht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic in storage upload flow
2 participants
@trueleo @nitisht