refactor: Bump to jasmine 5.4.0 #9453
Conversation
Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #9453 +/- ##
=======================================
Coverage 93.49% 93.49%
=======================================
Files 186 186
Lines 14810 14810
=======================================
Hits 13846 13846
Misses 964 964 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
| @@ -3691,7 +3692,7 @@ describe('Parse.User testing', () => { | |||
| done(); | |||
| }); | |||
| }); | |||
| }).pend('this test fails. See: https://github.com/parse-community/parse-server/issues/5097'); | |||
There was a problem hiding this comment.
Is the combined use of xit and .pend recommended? I thought one essentially excludes the other? Should xit be it when adding pend, or is there any advantage of combining them?
There was a problem hiding this comment.
xit.pend is not a function anymore
There was a problem hiding this comment.
I misread the diff file. You are removing .pend, not adding it. In that case we'd loose the info why this test is disabled. Wouldn't it be better to use this syntax:
it('should not send a verification email if the user signed up using oauth', async () => {
pending('this test fails. See: https://github.com/parse-community/parse-server/issues/5097');
}
- change from
xittoit - change from chained
.pendtopending()call inside test
There was a problem hiding this comment.
I tried it your way and the test failed. I added a comment so no info is lost
mtrezza
changed the title
This reverts commit 6879188.
Pull Request
Issue
Closes: #9399
Approach
doneis deprecated and should be replaced with async / awaitTasks