fix: Parse Server option `fileUpload.fileExtensions` fails to determine file extension if filename contains multiple dots #8754

MarcDerhammer · 2023-09-19T17:20:13Z

Pull Request

Report security issues confidentially.
Any contribution is under this license.
Link this pull request to an issue.

Issue

Closes: #8753

Approach

Use the last index of period to determine extension

Tasks

Add tests

related to parse-community#8753

parse-github-assistant · 2023-09-19T17:20:14Z

I will reformat the title to use the proper commit message syntax.

parse-github-assistant · 2023-09-19T17:20:17Z

Thanks for opening this pull request!

codecov · 2023-09-19T17:28:21Z

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (71dfd8a) 94.31% compared to head (933b5e7) 94.31%.
Report is 1 commits behind head on alpha.

❗ Current head 933b5e7 differs from pull request most recent head 3f26fda. Consider uploading reports for the commit 3f26fda to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##            alpha    #8754   +/-   ##
=======================================
  Coverage   94.31%   94.31%           
=======================================
  Files         186      186           
  Lines       14770    14770           
=======================================
  Hits        13931    13931           
  Misses        839      839

Files Changed	Coverage Δ
src/Routers/FilesRouter.js	`93.29% <100.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

spec/ParseFile.spec.js

…names

spec/ParseFile.spec.js

mtrezza

Almost there

spec/ParseFile.spec.js

Co-authored-by: Manuel <[email protected]> Signed-off-by: Marc Derhammer <[email protected]>

mtrezza

Looks good, waiting for CI to pass...

MarcDerhammer · 2023-09-22T16:27:17Z

PR title was too long, I shortened it to <90 chars

Edit: If that was fine as is, I can switch it back. Thought that was reason for the canceled/failed other tests. the Commit Message test had a ❌

parse-github-assistant · 2023-09-22T23:30:17Z

I will reformat the title to use the proper commit message syntax.

mtrezza · 2023-09-22T23:31:09Z

I've changed the bot to allow longer PR titles; the PR title check is unrelated to the other failing tests which are just flaky tests, so I'm re-running the CI until they pass.

mtrezza

Looks good! Thanks for picking this up!

# [6.4.0-alpha.3](6.4.0-alpha.2...6.4.0-alpha.3) (2023-09-23) ### Bug Fixes * Parse Server option `fileUpload.fileExtensions` fails to determine file extension if filename contains multiple dots ([#8754](#8754)) ([3d6d50e](3d6d50e))

parseplatformorg · 2023-09-23T20:44:55Z

🎉 This change has been released in version 6.4.0-alpha.3

# [6.5.0-beta.1](6.4.0...6.5.0-beta.1) (2023-11-16) ### Bug Fixes * Context not passed to Cloud Code Trigger `beforeFind` when using `Parse.Query.include` ([#8765](#8765)) ([7d32d89](7d32d89)) * Parse Server option `fileUpload.fileExtensions` fails to determine file extension if filename contains multiple dots ([#8754](#8754)) ([3d6d50e](3d6d50e)) * Security bump @babel/traverse from 7.20.5 to 7.23.2 ([#8777](#8777)) ([2d6b3d1](2d6b3d1)) * Security upgrade graphql from 16.6.0 to 16.8.1 ([#8758](#8758)) ([71dfd8a](71dfd8a)) ### Features * Add `$setOnInsert` operator to `Parse.Server.database.update` ([#8791](#8791)) ([f630a45](f630a45)) * Add compatibility for MongoDB Atlas Serverless and AWS Amazon DocumentDB with collation options `enableCollationCaseComparison`, `transformEmailToLowercase`, `transformUsernameToLowercase` ([#8805](#8805)) ([09fbeeb](09fbeeb)) * Add context to Cloud Code Triggers `beforeLogin` and `afterLogin` ([#8724](#8724)) ([a9c34ef](a9c34ef)) * Allow setting `createdAt` and `updatedAt` during `Parse.Object` creation with maintenance key ([#8696](#8696)) ([77bbfb3](77bbfb3))

parseplatformorg · 2023-11-16T15:59:06Z

🎉 This change has been released in version 6.5.0-beta.1

# [6.5.0-alpha.1](6.4.0...6.5.0-alpha.1) (2023-11-18) ### Bug Fixes * Context not passed to Cloud Code Trigger `beforeFind` when using `Parse.Query.include` ([#8765](#8765)) ([7d32d89](7d32d89)) * Parse Server option `fileUpload.fileExtensions` fails to determine file extension if filename contains multiple dots ([#8754](#8754)) ([3d6d50e](3d6d50e)) * Security bump @babel/traverse from 7.20.5 to 7.23.2 ([#8777](#8777)) ([2d6b3d1](2d6b3d1)) * Security upgrade graphql from 16.6.0 to 16.8.1 ([#8758](#8758)) ([71dfd8a](71dfd8a)) ### Features * Add `$setOnInsert` operator to `Parse.Server.database.update` ([#8791](#8791)) ([f630a45](f630a45)) * Add compatibility for MongoDB Atlas Serverless and AWS Amazon DocumentDB with collation options `enableCollationCaseComparison`, `transformEmailToLowercase`, `transformUsernameToLowercase` ([#8805](#8805)) ([09fbeeb](09fbeeb)) * Add context to Cloud Code Triggers `beforeLogin` and `afterLogin` ([#8724](#8724)) ([a9c34ef](a9c34ef)) * Allow setting `createdAt` and `updatedAt` during `Parse.Object` creation with maintenance key ([#8696](#8696)) ([77bbfb3](77bbfb3)) * Upgrade Parse Server Push Adapter to 5.0.2 ([#8813](#8813)) ([6ef1986](6ef1986))

parseplatformorg · 2023-11-18T13:55:46Z

🎉 This change has been released in version 6.5.0-alpha.1

# [6.5.0](6.4.0...6.5.0) (2024-03-01) ### Bug Fixes * Context not passed to Cloud Code Trigger `beforeFind` when using `Parse.Query.include` ([#8765](#8765)) ([7d32d89](7d32d89)) * Improve PostgreSQL injection detection; fixes security vulnerability [GHSA-6927-3vr9-fxf2](GHSA-6927-3vr9-fxf2) which affects Parse Server deployments using a Postgres database ([#8960](#8960)) ([a6e6549](a6e6549)) * Parse Server option `fileUpload.fileExtensions` fails to determine file extension if filename contains multiple dots ([#8754](#8754)) ([3d6d50e](3d6d50e)) * Security bump @babel/traverse from 7.20.5 to 7.23.2 ([#8777](#8777)) ([2d6b3d1](2d6b3d1)) * Security upgrade graphql from 16.6.0 to 16.8.1 ([#8758](#8758)) ([71dfd8a](71dfd8a)) ### Features * Add `$setOnInsert` operator to `Parse.Server.database.update` ([#8791](#8791)) ([f630a45](f630a45)) * Add compatibility for MongoDB Atlas Serverless and AWS Amazon DocumentDB with collation options `enableCollationCaseComparison`, `transformEmailToLowercase`, `transformUsernameToLowercase` ([#8805](#8805)) ([09fbeeb](09fbeeb)) * Add context to Cloud Code Triggers `beforeLogin` and `afterLogin` ([#8724](#8724)) ([a9c34ef](a9c34ef)) * Allow setting `createdAt` and `updatedAt` during `Parse.Object` creation with maintenance key ([#8696](#8696)) ([77bbfb3](77bbfb3)) * Upgrade Parse Server Push Adapter to 5.0.2 ([#8813](#8813)) ([6ef1986](6ef1986)) ### Performance Improvements * Improved IP validation performance for `masterKeyIPs`, `maintenanceKeyIPs` ([#8510](#8510)) ([b87daba](b87daba))

parseplatformorg · 2024-03-01T16:07:34Z

🎉 This change has been released in version 6.5.0

# [7.0.0](6.4.0...7.0.0) (2024-03-19) ### Bug Fixes * CacheAdapter does not connect when using a CacheAdapter with a JSON config ([#8633](#8633)) ([720d24e](720d24e)) * Conditional email verification not working in some cases if `verifyUserEmails`, `preventLoginWithUnverifiedEmail` set to functions ([#8838](#8838)) ([8e7a6b1](8e7a6b1)) * Context not passed to Cloud Code Trigger `beforeFind` when using `Parse.Query.include` ([#8765](#8765)) ([7d32d89](7d32d89)) * Deny request if master key is not set in Parse Server option `masterKeyIps` regardless of ACL and CLP ([#8957](#8957)) ([a7b5b38](a7b5b38)) * Docker image not published to Docker Hub on new release ([#8905](#8905)) ([a2ac8d1](a2ac8d1)) * Docker version releases by removing arm/v6 and arm/v7 support ([#8976](#8976)) ([1f62dd0](1f62dd0)) * GraphQL file upload fails in case of use of pointer or relation ([#8721](#8721)) ([1aba638](1aba638)) * Improve PostgreSQL injection detection; fixes security vulnerability [GHSA-6927-3vr9-fxf2](GHSA-6927-3vr9-fxf2) which affects Parse Server deployments using a Postgres database ([#8961](#8961)) ([cbefe77](cbefe77)) * Incomplete user object in `verifyEmail` function if both username and email are changed ([#8889](#8889)) ([1eb95ae](1eb95ae)) * Parse Server option `emailVerifyTokenReuseIfValid: true` generates new token on every email verification request ([#8885](#8885)) ([0023ce4](0023ce4)) * Parse Server option `fileExtensions` default value rejects file extensions that are less than 3 or more than 4 characters long ([#8699](#8699)) ([2760381](2760381)) * Parse Server option `fileUpload.fileExtensions` fails to determine file extension if filename contains multiple dots ([#8754](#8754)) ([3d6d50e](3d6d50e)) * Security bump @babel/traverse from 7.20.5 to 7.23.2 ([#8777](#8777)) ([2d6b3d1](2d6b3d1)) * Security upgrade graphql from 16.6.0 to 16.8.1 ([#8758](#8758)) ([71dfd8a](71dfd8a)) * Server crashes on invalid Cloud Function or Cloud Job name; fixes security vulnerability [GHSA-6hh7-46r2-vf29](GHSA-6hh7-46r2-vf29) ([#9024](#9024)) ([9f6e342](9f6e342)) * Server crashes when receiving an array of `Parse.Pointer` in the request body ([#8784](#8784)) ([66e3603](66e3603)) * Username is `undefined` in email verification link on email change ([#8887](#8887)) ([e315c13](e315c13)) ### Features * Add `$setOnInsert` operator to `Parse.Server.database.update` ([#8791](#8791)) ([f630a45](f630a45)) * Add `installationId` to arguments for `verifyUserEmails`, `preventLoginWithUnverifiedEmail` ([#8836](#8836)) ([a22dbe1](a22dbe1)) * Add `installationId`, `ip`, `resendRequest` to arguments passed to `verifyUserEmails` on verification email request ([#8873](#8873)) ([8adcbee](8adcbee)) * Add `Parse.User` as function parameter to Parse Server options `verifyUserEmails`, `preventLoginWithUnverifiedEmail` on login ([#8850](#8850)) ([972f630](972f630)) * Add compatibility for MongoDB Atlas Serverless and AWS Amazon DocumentDB with collation options `enableCollationCaseComparison`, `transformEmailToLowercase`, `transformUsernameToLowercase` ([#8805](#8805)) ([09fbeeb](09fbeeb)) * Add context to Cloud Code Triggers `beforeLogin` and `afterLogin` ([#8724](#8724)) ([a9c34ef](a9c34ef)) * Add password validation via POST request for user with unverified email using master key and option `ignoreEmailVerification` ([#8895](#8895)) ([633a9d2](633a9d2)) * Add support for MongoDB 7 ([#8761](#8761)) ([3de8494](3de8494)) * Add support for MongoDB query comment ([#8928](#8928)) ([2170962](2170962)) * Add support for Node 20, drop support for Node 14, 16 ([#8907](#8907)) ([ced4872](ced4872)) * Add support for Postgres 16 ([#8898](#8898)) ([99489b2](99489b2)) * Allow `Parse.Session.current` on expired session token instead of throwing error ([#8722](#8722)) ([f9dde4a](f9dde4a)) * Allow setting `createdAt` and `updatedAt` during `Parse.Object` creation with maintenance key ([#8696](#8696)) ([77bbfb3](77bbfb3)) * Deprecation DEPPS5: Config option `allowClientClassCreation` defaults to `false` ([#8849](#8849)) ([29624e0](29624e0)) * Deprecation DEPPS6: Authentication adapters disabled by default ([#8858](#8858)) ([0cf58eb](0cf58eb)) * Deprecation DEPPS7: Remove deprecated Cloud Code file trigger syntax ([#8855](#8855)) ([4e6a375](4e6a375)) * Deprecation DEPPS8: Parse Server option `allowExpiredAuthDataToken` defaults to `false` ([#8860](#8860)) ([e29845f](e29845f)) * Deprecation DEPPS9: LiveQuery `fields` option is renamed to `keys` ([#8852](#8852)) ([38983e8](38983e8)) * Node process exits with error code 1 on uncaught exception to allow custom uncaught exception handling ([#8894](#8894)) ([70c280c](70c280c)) * Switch GraphQL server from Yoga v2 to Apollo v4 ([#8959](#8959)) ([105ae7c](105ae7c)) * Upgrade Parse Server Push Adapter to 5.0.2 ([#8813](#8813)) ([6ef1986](6ef1986)) * Upgrade to Parse JS SDK 5 ([#9022](#9022)) ([ad4aa83](ad4aa83)) ### Performance Improvements * Improved IP validation performance for `masterKeyIPs`, `maintenanceKeyIPs` ([#8510](#8510)) ([b87daba](b87daba)) ### BREAKING CHANGES * The Parse Server option `allowClientClassCreation` defaults to `false`. ([29624e0](29624e0)) * A request using the master key will now be rejected as unauthorized if the IP from which the request originates is not set in the Parse Server option `masterKeyIps`, even if the request does not require the master key permission, for example for a public object in a public class class. ([a7b5b38](a7b5b38)) * Node process now exits with code 1 on uncaught exceptions, enabling custom handlers that were blocked by Parse Server's default behavior of re-throwing errors. This change may lead to automatic process restarts by the environment, unlike before. ([70c280c](70c280c)) * Authentication adapters are disabled by default; to use an authentication adapter it needs to be explicitly enabled in the Parse Server authentication adapter option `auth.<provider>.enabled: true` ([0cf58eb](0cf58eb)) * Parse Server option `allowExpiredAuthDataToken` defaults to `false`; a 3rd party authentication token will be validated every time the user tries to log in and the login will fail if the token has expired; the effect of this change may differ for different authentication adapters, depending on the token lifetime and the token refresh logic of the adapter ([e29845f](e29845f)) * LiveQuery `fields` option is renamed to `keys` ([38983e8](38983e8)) * Cloud Code file trigger syntax has been aligned with object trigger syntax, for example `Parse.Cloud.beforeDeleteFile'` has been changed to `Parse.Cloud.beforeDelete(Parse.File, (request) => {})'` ([4e6a375](4e6a375)) * Removes support for Node 14 and 16 ([ced4872](ced4872)) * Removes support for Postgres 11 and 12 ([99489b2](99489b2)) * The `Parse.User` passed as argument if `verifyUserEmails` is set to a function is renamed from `user` to `object` for consistency with invocations of `verifyUserEmails` on signup or login; the user object is not a plain JavaScript object anymore but an instance of `Parse.User` ([8adcbee](8adcbee)) * `Parse.Session.current()` no longer throws an error if the session token is expired, but instead returns the session token with its expiration date to allow checking its validity ([f9dde4a](f9dde4a)) * `Parse.Query` no longer supports the BSON type `code`; although this feature was never officially documented, its removal is announced as a breaking change to protect deployments where it might be in use. ([3de8494](3de8494))

parseplatformorg · 2024-03-19T20:51:05Z

🎉 This change has been released in version 7.0.0

fix: use last index of period to determine extension

09008bf

related to parse-community#8753

parse-github-assistant bot changed the title ~~fix: use last index of period to determine extension~~ fix: Use last index of period to determine extension Sep 19, 2023

mtrezza requested changes Sep 19, 2023

View reviewed changes

spec/ParseFile.spec.js Show resolved Hide resolved

Marc Derhammer added 2 commits September 19, 2023 16:30

Added some more testing for bad file extensions and also invalid file…

b2e90ff

…names

Change from split to lastIndexOf

884512d

MarcDerhammer requested a review from mtrezza September 20, 2023 01:23

mtrezza reviewed Sep 20, 2023

View reviewed changes

spec/ParseFile.spec.js Show resolved Hide resolved

mtrezza added 2 commits September 20, 2023 15:14

Merge branch 'alpha' into fix/extension-fix

9e9bc41

Merge branch 'alpha' into fix/extension-fix

c5db899

mtrezza changed the title ~~fix: Use last index of period to determine extension~~ fix: Parse Server option fileUpload.fileExtensions fails to determine file extension if filename contains multiple dots Sep 22, 2023

mtrezza requested changes Sep 22, 2023

View reviewed changes

spec/ParseFile.spec.js Outdated Show resolved Hide resolved

spec/ParseFile.spec.js Outdated Show resolved Hide resolved

MarcDerhammer and others added 2 commits September 21, 2023 21:46

Update spec/ParseFile.spec.js

2cd301f

Co-authored-by: Manuel <[email protected]> Signed-off-by: Marc Derhammer <[email protected]>

Update spec/ParseFile.spec.js

3f26fda

Co-authored-by: Manuel <[email protected]> Signed-off-by: Marc Derhammer <[email protected]>

mtrezza approved these changes Sep 22, 2023

View reviewed changes

MarcDerhammer changed the title ~~fix: Parse Server option fileUpload.fileExtensions fails to determine file extension if filename contains multiple dots~~ fix: fileUpload.fileExtensions misreads extension of filenames with multiple dots Sep 22, 2023

mtrezza changed the title ~~fix: fileUpload.fileExtensions misreads extension of filenames with multiple dots~~ fix: Parse Server option fileUpload.fileExtensions fails to determine file extension if filename contains multiple dots Sep 22, 2023

mtrezza changed the title ~~fix: Parse Server option fileUpload.fileExtensions fails to determine file extension if filename contains multiple dots~~ fix: parse Server option fileUpload.fileExtensions fails to determine file extension if filename contains multiple dots Sep 22, 2023

mtrezza approved these changes Sep 23, 2023

View reviewed changes

mtrezza merged commit 3d6d50e into parse-community:alpha Sep 23, 2023
24 checks passed

parseplatformorg added the state:released-alpha Released as alpha version label Sep 23, 2023

mtrezza mentioned this pull request Sep 29, 2023

Parse File Upload bug when multiple '.' in the filename #8769

Closed

4 tasks

parseplatformorg added the state:released-beta Released as beta version label Nov 16, 2023

parseplatformorg added the state:released-release-6.x.x label Mar 1, 2024

parseplatformorg added the state:released Released as stable version label Mar 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Parse Server option `fileUpload.fileExtensions` fails to determine file extension if filename contains multiple dots #8754

fix: Parse Server option `fileUpload.fileExtensions` fails to determine file extension if filename contains multiple dots #8754

MarcDerhammer commented Sep 19, 2023 •

edited by mtrezza

Loading

parse-github-assistant bot commented Sep 19, 2023

parse-github-assistant bot commented Sep 19, 2023

codecov bot commented Sep 19, 2023 •

edited

Loading

mtrezza left a comment •

edited

Loading

mtrezza left a comment

MarcDerhammer commented Sep 22, 2023 •

edited

Loading

parse-github-assistant bot commented Sep 22, 2023

mtrezza commented Sep 22, 2023 •

edited

Loading

mtrezza left a comment

parseplatformorg commented Sep 23, 2023

parseplatformorg commented Nov 16, 2023

parseplatformorg commented Nov 18, 2023

parseplatformorg commented Mar 1, 2024

parseplatformorg commented Mar 19, 2024

fix: Parse Server option fileUpload.fileExtensions fails to determine file extension if filename contains multiple dots #8754

fix: Parse Server option fileUpload.fileExtensions fails to determine file extension if filename contains multiple dots #8754

Conversation

MarcDerhammer commented Sep 19, 2023 • edited by mtrezza Loading

Pull Request

Issue

Approach

Tasks

parse-github-assistant bot commented Sep 19, 2023

parse-github-assistant bot commented Sep 19, 2023

Thanks for opening this pull request!

codecov bot commented Sep 19, 2023 • edited Loading

Codecov Report

mtrezza left a comment • edited Loading

Choose a reason for hiding this comment

mtrezza left a comment

Choose a reason for hiding this comment

MarcDerhammer commented Sep 22, 2023 • edited Loading

parse-github-assistant bot commented Sep 22, 2023

mtrezza commented Sep 22, 2023 • edited Loading

mtrezza left a comment

Choose a reason for hiding this comment

parseplatformorg commented Sep 23, 2023

parseplatformorg commented Nov 16, 2023

parseplatformorg commented Nov 18, 2023

parseplatformorg commented Mar 1, 2024

parseplatformorg commented Mar 19, 2024

fix: Parse Server option `fileUpload.fileExtensions` fails to determine file extension if filename contains multiple dots #8754

fix: Parse Server option `fileUpload.fileExtensions` fails to determine file extension if filename contains multiple dots #8754

MarcDerhammer commented Sep 19, 2023 •

edited by mtrezza

Loading

codecov bot commented Sep 19, 2023 •

edited

Loading

mtrezza left a comment •

edited

Loading

MarcDerhammer commented Sep 22, 2023 •

edited

Loading

mtrezza commented Sep 22, 2023 •

edited

Loading