refactor: upgrade @graphql-yoga/node from 2.6.0 to 2.6.1 #8043
Conversation
Snyk has created this PR to upgrade @graphql-yoga/node from 2.6.0 to 2.6.1. See this package in npm: https://www.npmjs.com/package/@graphql-yoga/node See this project in Snyk: https://app.snyk.io/org/acinader/project/21343059-02d9-4182-87d7-718a44b181ef?utm_source=github&utm_medium=referral&page=upgrade-pr
|
I will reformat the title to use the proper commit message syntax. |
parse-github-assistant
bot
changed the title
Thanks for opening this pull request!
|
Codecov Report
@@ Coverage Diff @@
## alpha #8043 +/- ##
===========================================
- Coverage 94.14% 84.14% -10.01%
===========================================
Files 182 182
Lines 13691 13691
===========================================
- Hits 12890 11520 -1370
- Misses 801 2171 +1370
Continue to review full report at Codecov.
|
|
Interesting that a patch version upgrade causes tests to fail. Either yoga didn't follow semver, or our tests are too strict. |
|
@mtrezza I sent a message to the Guild, they will investigate asap I think. The failing test is related to an addition that I asked about max file upload size to keep same features as the old graphql-upload package. May be something is not correctlu covered on their side and our test suite has catched the error. I added this test during the Yoga gql switch |
|
Hey there, we decided that the status code 500 is incorrect as the user is responsible for sending a file that exceeds the limit. Thus 400 makes a lot more sense. We treated this change as a bug fix. |
|
thanks @n1ru4l i'll take a look to update the test |
|
@n1ru4l Changing the error code is a breaking change; does that mean Yoga doesn't follow semver? |
|
Hey @mtrezza, Yoga follows semantic versioning. Sometimes it is hard to define what is considered a breaking change. From our perspective, the file upload limit was undocumented and treated as unstable. As we are adding tests for the feature we realized that we implemented it not according to the reference specification. https://github.com/jaydenseric/graphql-upload/blob/b1cdd2a913c5394b5ff5f89b28d79b949b0bdde5/processRequest.js#L175 Apparently we also messed up again as the status code should be 413. 😭 |
|
In semver any breaking change (of an exposed API) requires a major increment, regardless of adoption rate. I'm asking for us to know whether we have to be careful in the future when upgrading Yoga if it follows a "romantic" interpretation of semver. |
Do you treat something like adding a property to an object as a breaking change? If someone uses We aim to follow strict semantic versioning and will take your concern into account regarding future "romantic breaking" changes. |
In projects where a high level of stability is required, these aspects are usually defined. You could say "the order / number of properties may change". I don't think we are at this level however when talking about a HTTP response code. If the response code is part of the public API, then strictly following semver means it's a breaking change. |
|
Hi @mtrezza , @n1ru4l, I think that a breaking change was maybe introduced. But this is why I added a test during my development on yoga since I know that the size limit feature was introduced in yoga for Parse Server to meet our requirements for the migration. Btw, @mtrezza @n1ru4l, anyone open to send the really quick PR to fix the status code ? |
|
Closing due to conflicts; waiting for snyk to open a new PR. |
This PR was automatically created by Snyk using the credentials of a real user.
Snyk has created this PR to upgrade @graphql-yoga/node from 2.6.0 to 2.6.1.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
Release notes
Package name: @graphql-yoga/node
-
2.6.1 - 2022-05-23
-
2.6.1-canary-bfb3b22.0 - 2022-05-23
-
2.6.1-canary-65224d9.0 - 2022-05-23
-
2.6.0 - 2022-05-12
from @graphql-yoga/node GitHub release notesCommit messages
Package name: @graphql-yoga/node
Compare
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs