Winston 3 upgrade #5496

stage88 · 2019-04-11T12:45:45Z

There are 5 tests failing, however I don't think these are related.

* ⚡ Release 3.1.3 * Update CHANGELOG.md

Bumps [winston](https://github.com/winstonjs/winston) and [winston-daily-rotate-file](https://github.com/winstonjs/winston-daily-rotate-file). These dependencies needed to be updated together. Updates `winston` from 2.4.4 to 3.1.0 - [Release notes](https://github.com/winstonjs/winston/releases) - [Changelog](https://github.com/winstonjs/winston/blob/master/CHANGELOG.md) - [Commits](winstonjs/winston@2.4.4...3.1.0) Updates `winston-daily-rotate-file` from 1.7.2 to 3.5.1 - [Release notes](https://github.com/winstonjs/winston-daily-rotate-file/releases) - [Commits](winstonjs/winston-daily-rotate-file@v1.7.2...v3.5.1) Signed-off-by: dependabot[bot] <[email protected]>

Bumps [winston](https://github.com/winstonjs/winston) and [winston-daily-rotate-file](https://github.com/winstonjs/winston-daily-rotate-file). These dependencies needed to be updated together. Updates `winston` from 2.4.4 to 3.2.0 - [Release notes](https://github.com/winstonjs/winston/releases) - [Changelog](https://github.com/winstonjs/winston/blob/master/CHANGELOG.md) - [Commits](winstonjs/winston@2.4.4...3.2.0) Updates `winston-daily-rotate-file` from 1.7.2 to 3.6.0 - [Release notes](https://github.com/winstonjs/winston-daily-rotate-file/releases) - [Commits](winstonjs/winston-daily-rotate-file@v1.7.2...v3.6.0) Signed-off-by: dependabot[bot] <[email protected]>

# Conflicts: # package-lock.json # package.json

# Conflicts: # package-lock.json

acinader

This is great.

The failing tests are a problem that needs to be researched and may be a byproduct of dependency upgrades

2) MongoStorageAdapter auto-escapes symbols in auth information
  - Unhandled promise rejection: TypeError: Cannot read property 's' of null
3) MongoStorageAdapter doesn't double escape already URI-encoded information
  - Unhandled promise rejection: TypeError: Cannot read property 's' of null
4) MongoStorageAdapter preserves replica sets
  - Unhandled promise rejection: TypeError: Cannot read property 's' of null

I rebased locally to get other dependency changes and I still get the above.

acinader · 2019-04-11T15:47:07Z

src/Adapters/Logger/WinstonLogger.js

-  });
-  _.remove(additionalTransports, transport => {
-    return transport.name === transportName;
+  const matchingTransport = logger.transports.find(t1 => {


do we have to worry about if there are multiple transport of a particular kind? ie two file transports, one for error and one for info? I'm not sure.

Yes I think you are right, the code has changed so now it might be possible to have two transports with the same name.

I think previously this code prevented the above scenario.

additionalTransports.forEach(transport => { transports[transport.name] = transport; });

I'll investigate...

acinader · 2019-04-11T15:51:11Z

src/Adapters/Logger/WinstonLogger.js

-      delete transports['parse-server-error'];
-    } else if (!_.isUndefined(options.dirname)) {
-      transports['parse-server'] = new DailyRotateFile(
+    if (!_.isUndefined(options.dirname) && !_.isNull(options.dirname)) {


can use: https://lodash.com/docs/4.17.11#isNil

No worries, i'll update to use isNil

Thanks @acinader, I'll investigate the failing tests.

stage88 · 2019-04-13T11:23:47Z

I think tests started failing since a jasmine upgrade from 3.1.0 to 3.4.0 via this commit e396612. Downgrading to 3.1.0 fixes the breaking tests.

I'll update failing tests to set up a spy with a return value that won't throw exceptions so that we don't have to downgrade jasmine.

codecov · 2019-04-13T11:45:04Z

Codecov Report

Merging #5496 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5496      +/-   ##
==========================================
- Coverage   94.04%   93.98%   -0.06%     
==========================================
  Files         125      125              
  Lines        9097     9092       -5     
==========================================
- Hits         8555     8545      -10     
- Misses        542      547       +5

Impacted Files	Coverage Δ
src/Routers/FilesRouter.js	`58.88% <100%> (ø)`	⬆️
src/middlewares.js	`98.2% <100%> (ø)`	⬆️
src/Adapters/Logger/WinstonLogger.js	`100% <100%> (ø)`	⬆️
src/Adapters/Logger/WinstonLoggerAdapter.js	`84.61% <100%> (ø)`	⬆️
src/Adapters/Auth/httpsRequest.js	`95.23% <0%> (-4.77%)`	⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js	`91.97% <0%> (-0.25%)`	⬇️
src/RestWrite.js	`92.89% <0%> (-0.19%)`	⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js	`97.01% <0%> (-0.17%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 019cf0a...03edd30. Read the comment docs.

acinader · 2019-04-13T17:07:20Z

@stage88 I didn't realize that jasmine has been breaking the tests since its last upgrade. I am going to take a look at the release notice to understand what is going on and I will also look at your fix. See #5500

Will get this merged in after that. This looks great. Big thanks for undertaking this chore!

stage88 · 2019-04-14T03:03:57Z

Should I try and fix the code as per your comment above: #5496 (comment)?

I should be able to have it done tonight ...

acinader · 2019-04-14T22:51:42Z

fixes: #5275

* ⚡ Release 3.1.3 (parse-community#5267) * ⚡ Release 3.1.3 * Update CHANGELOG.md * ⬆️ Bump winston and winston-daily-rotate-file Bumps [winston](https://github.com/winstonjs/winston) and [winston-daily-rotate-file](https://github.com/winstonjs/winston-daily-rotate-file). These dependencies needed to be updated together. Updates `winston` from 2.4.4 to 3.1.0 - [Release notes](https://github.com/winstonjs/winston/releases) - [Changelog](https://github.com/winstonjs/winston/blob/master/CHANGELOG.md) - [Commits](winstonjs/winston@2.4.4...3.1.0) Updates `winston-daily-rotate-file` from 1.7.2 to 3.5.1 - [Release notes](https://github.com/winstonjs/winston-daily-rotate-file/releases) - [Commits](winstonjs/winston-daily-rotate-file@v1.7.2...v3.5.1) Signed-off-by: dependabot[bot] <[email protected]> * Rewrote WinstonLogger to work with winston 3.x api * Changed winston logger test to use winston-transport * Added winston-transport dependency * Close and remove transports before adding them again * Changed to strict equal * Override adapter name * Updated and added getLogs tests * Bump winston and winston-daily-rotate-file Bumps [winston](https://github.com/winstonjs/winston) and [winston-daily-rotate-file](https://github.com/winstonjs/winston-daily-rotate-file). These dependencies needed to be updated together. Updates `winston` from 2.4.4 to 3.2.0 - [Release notes](https://github.com/winstonjs/winston/releases) - [Changelog](https://github.com/winstonjs/winston/blob/master/CHANGELOG.md) - [Commits](winstonjs/winston@2.4.4...3.2.0) Updates `winston-daily-rotate-file` from 1.7.2 to 3.6.0 - [Release notes](https://github.com/winstonjs/winston-daily-rotate-file/releases) - [Commits](winstonjs/winston-daily-rotate-file@v1.7.2...v3.6.0) Signed-off-by: dependabot[bot] <[email protected]> * Fixed tests, updated parse logging * Fixed tests, better error logging * Fix failing tests * Updates as per review

flovilmart and others added 15 commits December 29, 2018 14:01

⚡ Release 3.1.3 (parse-community#5267)

eb0bdaf

* ⚡ Release 3.1.3 * Update CHANGELOG.md

Rewrote WinstonLogger to work with winston 3.x api

d06312b

Changed winston logger test to use winston-transport

85b3a7d

Added winston-transport dependency

6401cd7

Close and remove transports before adding them again

8cf23cf

Changed to strict equal

10e0252

Override adapter name

65d0aa8

Updated and added getLogs tests

3ee6e2a

Merged with Bump winston and winston-daily-rotate-file

30a88f3

Merge branch 'feature/winston-3-migration' into winston-3

1722cbc

# Conflicts: # package-lock.json # package.json

Fixed tests, updated parse logging

eb4d379

Fixed tests, better error logging

fd70d22

Merge branch 'master' into winston-3

986744a

# Conflicts: # package-lock.json

acinader suggested changes Apr 11, 2019

View reviewed changes

Fix failing tests

06ad6fd

Merge branch 'master' into winston-3

be30e0a

acinader mentioned this pull request Apr 13, 2019

Track Down Unhandled rejections #5502

Closed

Updates as per review

03edd30

acinader mentioned this pull request Apr 14, 2019

Feature/winston 3 migration #5275

Closed

acinader merged commit 6ffc413 into parse-community:master Apr 14, 2019

dplewis mentioned this pull request Apr 18, 2019

Upgrade Winston to 3 #5400

Closed

stage88 deleted the winston-3 branch April 29, 2023 06:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Winston 3 upgrade #5496

Winston 3 upgrade #5496

stage88 commented Apr 11, 2019

acinader left a comment •

edited

Loading

acinader Apr 11, 2019

stage88 Apr 11, 2019

acinader Apr 11, 2019

stage88 Apr 11, 2019

stage88 Apr 11, 2019

stage88 commented Apr 13, 2019

codecov bot commented Apr 13, 2019 •

edited

Loading

acinader commented Apr 13, 2019

stage88 commented Apr 14, 2019

acinader commented Apr 14, 2019

Winston 3 upgrade #5496

Winston 3 upgrade #5496

Conversation

stage88 commented Apr 11, 2019

acinader left a comment • edited Loading

Choose a reason for hiding this comment

acinader Apr 11, 2019

Choose a reason for hiding this comment

stage88 Apr 11, 2019

Choose a reason for hiding this comment

acinader Apr 11, 2019

Choose a reason for hiding this comment

stage88 Apr 11, 2019

Choose a reason for hiding this comment

stage88 Apr 11, 2019

Choose a reason for hiding this comment

stage88 commented Apr 13, 2019

codecov bot commented Apr 13, 2019 • edited Loading

Codecov Report

acinader commented Apr 13, 2019

stage88 commented Apr 14, 2019

acinader commented Apr 14, 2019

acinader left a comment •

edited

Loading

codecov bot commented Apr 13, 2019 •

edited

Loading