Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG: Fix containedIn query on empty array #5254

Merged
merged 2 commits into from
Dec 19, 2018

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Dec 19, 2018

closes: #4727

Fixes both containedIn and notContainedIn

flovilmart
flovilmart previously approved these changes Dec 19, 2018
@codecov
Copy link

codecov bot commented Dec 19, 2018

Codecov Report

Merging #5254 into master will decrease coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5254      +/-   ##
==========================================
- Coverage   93.89%   93.88%   -0.01%     
==========================================
  Files         123      123              
  Lines        8965     8968       +3     
==========================================
+ Hits         8418     8420       +2     
- Misses        547      548       +1
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.15% <75%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 631b168...bba5f71. Read the comment docs.

@dplewis dplewis merged commit ab32dbc into parse-community:master Dec 19, 2018
@dplewis dplewis deleted the pg-nin-empty branch December 19, 2018 23:57
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* PG: Fix containedIn query on empty array

* improve logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres doesn't support this query type yet {"$nin":[]}
2 participants