Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve column sorting preferences in data browser #2016

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

damianstasik
Copy link
Contributor

New Pull Request Checklist

Issue Description

This PR fixes order of execution inside prefetchData which was causing sorting preferences to be ignored on the first load.

Related issue: #1992

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jan 24, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mtrezza
Copy link
Member

mtrezza commented Jan 25, 2022

@404-html does this fix the issue you reported?

@404-html
Copy link
Member

Work like a charm, thanks 🙌

@mtrezza mtrezza changed the title fix: preserve column sorting preferences on first load fix: preserve column sorting preferences in data browser Jan 26, 2022
@mtrezza mtrezza merged commit c2e6557 into parse-community:alpha Jan 26, 2022
parseplatformorg pushed a commit that referenced this pull request Jan 26, 2022
# [4.0.0-alpha.15](4.0.0-alpha.14...4.0.0-alpha.15) (2022-01-26)

### Bug Fixes

* preserve column sorting preferences in data browser ([#2016](#2016)) ([c2e6557](c2e6557))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0-alpha.15

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jan 26, 2022
parseplatformorg pushed a commit that referenced this pull request Feb 6, 2022
# [4.0.0-beta.3](4.0.0-beta.2...4.0.0-beta.3) (2022-02-06)

### Bug Fixes

* bump follow-redirects from 1.14.4 to 1.14.7 ([#1997](#1997)) ([4ca2e97](4ca2e97))
* bump markdown-it from 12.3.0 to 12.3.2 ([#1996](#1996)) ([245c22e](245c22e))
* bump marked from 0.8.2 to 4.0.10 ([#2001](#2001)) ([ae4cc90](ae4cc90))
* bump nanoid from 3.1.28 to 3.2.0 ([#2008](#2008)) ([6cfe9ca](6cfe9ca))
* calendar widget layout partly hides last days of a month ([#1990](#1990)) ([5bd86dd](5bd86dd))
* cannot save nullish values for required fields ([#2003](#2003)) ([e1a5497](e1a5497))
* crash when checking for new dashboard release without internet connection ([#2015](#2015)) ([8c36e69](8c36e69))
* preserve column sorting preferences in data browser ([#2016](#2016)) ([c2e6557](c2e6557))
* upgrade parse from 3.4.0 to 3.4.1 ([#2011](#2011)) ([68cf9e2](68cf9e2))
* various UI bugs (e.g. filter data browser, switch app, upload file) ([#2010](#2010)) ([a508a58](a508a58))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0-beta.3

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Feb 6, 2022
parseplatformorg pushed a commit that referenced this pull request Mar 3, 2022
## [4.0.1](4.0.0...4.0.1) (2022-03-03)

### Bug Fixes

* bump follow-redirects from 1.14.4 to 1.14.7 ([#1997](#1997)) ([4ca2e97](4ca2e97))
* bump markdown-it from 12.3.0 to 12.3.2 ([#1996](#1996)) ([245c22e](245c22e))
* bump marked from 0.8.2 to 4.0.10 ([#2001](#2001)) ([ae4cc90](ae4cc90))
* bump nanoid from 3.1.28 to 3.2.0 ([#2008](#2008)) ([6cfe9ca](6cfe9ca))
* calendar widget layout partly hides last days of a month ([#1990](#1990)) ([5bd86dd](5bd86dd))
* cannot save nullish values for required fields ([#2003](#2003)) ([e1a5497](e1a5497))
* crash when checking for new dashboard release without internet connection ([#2015](#2015)) ([8c36e69](8c36e69))
* preserve column sorting preferences in data browser ([#2016](#2016)) ([c2e6557](c2e6557))
* upgrade parse from 3.4.0 to 3.4.1 ([#2011](#2011)) ([68cf9e2](68cf9e2))
* various UI bugs (e.g. filter data browser, switch app, upload file) ([#2010](#2010)) ([a508a58](a508a58))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.1

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 3, 2022
beiguancyc pushed a commit to beiguancyc/parse-dashboard that referenced this pull request Mar 4, 2022
* source: (43 commits)
  chore(release): 4.0.1 [skip ci]
  ci: release commit
  chore(release): 4.0.0-beta.3 [skip ci]
  ci: release commit
  refactor: upgrade prismjs from 1.25.0 to 1.26.0 (parse-community#2019)
  chore(release): 4.0.0-alpha.15 [skip ci]
  fix: preserve column sorting preferences in data browser (parse-community#2016)
  refactor: upgrade prop-types from 15.8.0 to 15.8.1 (parse-community#2018)
  refactor: upgrade otpauth from 7.0.8 to 7.0.9 (parse-community#2017)
  chore(release): 4.0.0-alpha.14 [skip ci]
  fix: crash when checking for new dashboard release without internet connection (parse-community#2015)
  chore(release): 4.0.0-alpha.13 [skip ci]
  fix: calendar widget layout partly hides last days of a month (parse-community#1990)
  refactor: change example config Parse Server port from 1338 to 1337 (parse-community#2012)
  chore(release): 4.0.0-alpha.12 [skip ci]
  fix: upgrade parse from 3.4.0 to 3.4.1 (parse-community#2011)
  chore(release): 4.0.0-alpha.11 [skip ci]
  fix: various UI bugs (e.g. filter data browser, switch app, upload file) (parse-community#2010)
  chore(release): 4.0.0-alpha.10 [skip ci]
  fix: bump nanoid from 3.1.28 to 3.2.0 (parse-community#2008)
  ...

# Conflicts:
#	package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants