Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add visual distinction in data browser for internal classes and display their real names with underscore #1878

Merged
merged 4 commits into from
Oct 20, 2021
Merged

feat: add visual distinction in data browser for internal classes and display their real names with underscore #1878

merged 4 commits into from
Oct 20, 2021

Conversation

damianstasik
Copy link
Contributor

@damianstasik damianstasik commented Oct 20, 2021 •
edited
Loading

New Pull Request Checklist

Issue Description

This PR refactors parts of the app that shows class names so that it displays the real name (the one with an underscore). Additionally, there is now also a separator between internal and custom classes in the browser sidebar.

Related issue: #1849

Approach

  • Show real class names
  • Add separator between internal and custom classes

TODOs before merging

  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 20, 2021 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@damianstasik damianstasik mentioned this pull request Oct 20, 2021
Closed
@damianstasik damianstasik marked this pull request as ready for review October 20, 2021 14:43
@damianstasik
Copy link
Contributor Author

There are a few ways of implementing the separator:

  1. Using separate <CategoryList /> in the Browser.react.js, but that would mean the separator would be a feature only available in the browser sidebar.
  2. Adding a new type of category item with a new property called type, in this case, it would include only separator and would be handled for any CategoryList instance.
  3. Combination of 1&2 would be allowing a component property in the category list which could be used in Browser.react.js to add a custom separator only for the browser sidebar.

I chose the second option as it does not produce a duplicated code if other sections of the dashboard would also want a separator between categories.

mtrezza
mtrezza approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza changed the title refactor: distinguish external from internal classes by showing real name with underscore feat: add visual distinction in data browser for internal classes and display their real names with underscore Oct 20, 2021
@mtrezza mtrezza merged commit ac8d85e into parse-community:alpha Oct 20, 2021
parseplatformorg pushed a commit that referenced this pull request Oct 20, 2021
@semantic-release-bot
chore(release): 3.3.0-alpha.9 [skip ci]
1f65f47 
# [3.3.0-alpha.9](3.3.0-alpha.8...3.3.0-alpha.9) (2021-10-20)

### Features

* add visual distinction in data browser for internal classes and display their real names with underscore ([#1878](#1878)) ([ac8d85e](ac8d85e))
@parseplatformorg
Copy link
Contributor

🎉 This pull request has been released in version 3.3.0-alpha.9

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Oct 20, 2021
@snyk-bot snyk-bot mentioned this pull request Oct 31, 2021
Merged
parseplatformorg pushed a commit that referenced this pull request Nov 1, 2021
@semantic-release-bot
chore(release): 3.3.0-beta.1 [skip ci]
3ec64c3 
# [3.3.0-beta.1](3.2.1-beta.1...3.3.0-beta.1) (2021-11-01)

### Bug Fixes

* always pass boolean value when toggling checkbox ([#1872](#1872)) ([2e9fd59](2e9fd59))
* app icons are cropped in the app list for small screen sizes ([#1876](#1876)) ([9fc56a6](9fc56a6))
* link icon in pointer cell not visible when cell is too narrow ([#1856](#1856)) ([69b897d](69b897d))
* manual column preferences are overwritten by columnPreference option on page refresh ([#1881](#1881)) ([7232b0b](7232b0b))
* notification to upgrade dashboard for latest features not working ([#1894](#1894)) ([81361b6](81361b6))
* upgrade graphql from 15.4.0 to 15.6.0 ([#1853](#1853)) ([fca9b14](fca9b14))
* upgrade graphql from 15.6.0 to 15.6.1 ([#1887](#1887)) ([0cfe59e](0cfe59e))
* upgrade inquirer from 8.1.3 to 8.2.0 ([#1886](#1886)) ([c77f335](c77f335))
* upgrade passport from 0.4.1 to 0.5.0 ([#1865](#1865)) ([8d845f0](8d845f0))
* upload of file as default value fails when adding a new column ([#1875](#1875)) ([6040dd0](6040dd0))

### Features

* add config option `columnPreference.filterSortToTop` to set column name order in filter dialog ([#1884](#1884)) ([3acbda1](3acbda1))
* add pointer representation by a chosen column instead of objectId ([#1852](#1852)) ([d747786](d747786))
* add visual distinction in data browser for internal classes and display their real names with underscore ([#1878](#1878)) ([ac8d85e](ac8d85e))
* allow GraphIQL headers ([#1836](#1836)) ([3afcf73](3afcf73))
* allow graphQL headers ([34536b3](34536b3))

### Reverts

* Revert "Update CloudCode.react.js" ([eea1e2d](eea1e2d))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
parseplatformorg pushed a commit that referenced this pull request Jan 1, 2022
@semantic-release-bot
chore(release): 3.3.0 [skip ci]
b8226a2 
# [3.3.0](3.2.1...3.3.0) (2022-01-01)

### Bug Fixes

* always pass boolean value when toggling checkbox ([#1872](#1872)) ([2e9fd59](2e9fd59))
* app icons are cropped in the app list for small screen sizes ([#1876](#1876)) ([9fc56a6](9fc56a6))
* bump graphiql from 1.4.6 to 1.4.7 ([#1920](#1920)) ([35fd021](35fd021))
* context menu in data browser not opening for cell of type number ([#1913](#1913)) ([8731c35](8731c35))
* link icon in pointer cell not visible when cell is too narrow ([#1856](#1856)) ([69b897d](69b897d))
* manual column preferences are overwritten by columnPreference option on page refresh ([#1881](#1881)) ([7232b0b](7232b0b))
* notification to upgrade dashboard for latest features not working ([#1894](#1894)) ([81361b6](81361b6))
* upgrade graphql from 15.4.0 to 15.6.0 ([#1853](#1853)) ([fca9b14](fca9b14))
* upgrade graphql from 15.6.0 to 15.6.1 ([#1887](#1887)) ([0cfe59e](0cfe59e))
* upgrade inquirer from 8.1.3 to 8.2.0 ([#1886](#1886)) ([c77f335](c77f335))
* upgrade passport from 0.4.1 to 0.5.0 ([#1865](#1865)) ([8d845f0](8d845f0))
* upload of file as default value fails when adding a new column ([#1875](#1875)) ([6040dd0](6040dd0))

### Features

* add config option `columnPreference.filterSortToTop` to set column name order in filter dialog ([#1884](#1884)) ([3acbda1](3acbda1))
* add pointer representation by a chosen column instead of objectId ([#1852](#1852)) ([d747786](d747786))
* add visual distinction in data browser for internal classes and display their real names with underscore ([#1878](#1878)) ([ac8d85e](ac8d85e))
* allow GraphIQL headers ([#1836](#1836)) ([3afcf73](3afcf73))
* allow graphQL headers ([34536b3](34536b3))

### Reverts

* Revert "Update CloudCode.react.js" ([eea1e2d](eea1e2d))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jan 1, 2022
@mtrezza mtrezza mentioned this pull request Feb 10, 2022
Closed
4 tasks
@KodeDave KodeDave mentioned this pull request Feb 10, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@damianstasik @parseplatformorg @mtrezza @visualfanatic