fix: Error in web context when window.indexedDB API is available but protected
#2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! |
4 tasks
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2039 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 61 61
Lines 6176 6178 +2
Branches 1496 1496
=========================================
+ Hits 6176 6178 +2
☔ View full report in Codecov by Sentry. |
dplewis
changed the title
mtrezza
changed the title
window.indexedDB API is available but protected
|
@westhom do you want to try out this PR before we merge it, so we know it fixes the issue you reported? |
|
Thanks for the quick fix @dplewis . @mtrezza Can you advise on the best way of testing? I'm having issues with my build pipeline, that I don't see with the npm published package. This is what I'm doing:
The fix looks like it should work but currently unable to test. |
parseplatformorg
pushed a commit
that referenced
this pull request
Oct 7, 2023
# [4.3.0-alpha.4](4.3.0-alpha.3...4.3.0-alpha.4) (2023-10-07) ### Bug Fixes * Error in web context when `window.indexedDB` API is available but protected ([#2039](#2039)) ([360981f](360981f))
|
🎉 This change has been released in version 4.3.0-alpha.4 |
|
@westhom No problem! I got it done fast because it was on my list. Let me know if you have more issues with Figma plugins. I don’t know what that is lol |
|
@dplewis I can confirm that the latest parse@alpha release via npm is now importable inside Figma web context! Thx for the quick fix. |
parseplatformorg
pushed a commit
that referenced
this pull request
Nov 16, 2023
## [4.3.1-beta.1](4.3.0...4.3.1-beta.1) (2023-11-16) ### Bug Fixes * Connection failure in `Parse.Object.saveEventually` and `Parse.Object.destroyEventually` not handled on custom `Parse.Error.CONNECTION_FAILURE` message ([#2032](#2032)) ([4da3ebc](4da3ebc)) * Docs fail with `Cannot find module 'taffydb'` ([#2036](#2036)) ([dc91d0f](dc91d0f)) * Error in web context when `window.indexedDB` API is available but protected ([#2039](#2039)) ([360981f](360981f)) * Security upgrade browserify-sign from 4.2.1 to 4.2.2 ([#2043](#2043)) ([fd50b9d](fd50b9d)) * Security upgrade crypto-js from 4.1.1 to 4.2.0 ([#2042](#2042)) ([681fbdf](681fbdf))
|
🎉 This change has been released in version 4.3.1-beta.1 |
parseplatformorg
pushed a commit
that referenced
this pull request
Nov 18, 2023
## [4.3.1](4.3.0...4.3.1) (2023-11-18) ### Bug Fixes * Connection failure in `Parse.Object.saveEventually` and `Parse.Object.destroyEventually` not handled on custom `Parse.Error.CONNECTION_FAILURE` message ([#2032](#2032)) ([4da3ebc](4da3ebc)) * Docs fail with `Cannot find module 'taffydb'` ([#2036](#2036)) ([dc91d0f](dc91d0f)) * Error in web context when `window.indexedDB` API is available but protected ([#2039](#2039)) ([360981f](360981f)) * Security upgrade browserify-sign from 4.2.1 to 4.2.2 ([#2043](#2043)) ([fd50b9d](fd50b9d)) * Security upgrade crypto-js from 4.1.1 to 4.2.0 ([#2042](#2042)) ([681fbdf](681fbdf))
|
🎉 This change has been released in version 4.3.1 |
parseplatformorg
pushed a commit
that referenced
this pull request
Nov 18, 2023
## [4.3.1-alpha.1](4.3.0...4.3.1-alpha.1) (2023-11-18) ### Bug Fixes * Connection failure in `Parse.Object.saveEventually` and `Parse.Object.destroyEventually` not handled on custom `Parse.Error.CONNECTION_FAILURE` message ([#2032](#2032)) ([4da3ebc](4da3ebc)) * Docs fail with `Cannot find module 'taffydb'` ([#2036](#2036)) ([dc91d0f](dc91d0f)) * Error in web context when `window.indexedDB` API is available but protected ([#2039](#2039)) ([360981f](360981f)) * Security upgrade browserify-sign from 4.2.1 to 4.2.2 ([#2043](#2043)) ([fd50b9d](fd50b9d)) * Security upgrade crypto-js from 4.1.1 to 4.2.0 ([#2042](#2042)) ([681fbdf](681fbdf))
|
🎉 This change has been released in version 4.3.1-alpha.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
In a web context where window.indexedDB is protected from use but does exists, Parse SDK throws an error on initial import
Closes: #2038
Approach
Parse.IndexedDBTasks