feat/container-based-build #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pooriaPoorsarvi
commented
Oct 28, 2024
pooriaPoorsarvi
commented
- Adds docker build
- Supports runq through docker
- supports pulling image as a stand-alone for use
branylagaffe
force-pushed
the
feature/docker-container
branch
from
8617a46 to
895affa
Compare
|
I have reviewed the Dockerfile, which is fine for building. The following still needs to be done
|
updated build command and image entry point updated build step for knottykraken updated docker files updated dockerfile
updated docker deps updated docker run sec to be able to run gdb without the warnings updated dockerfile and runq
branylagaffe
force-pushed
the
feature/docker-container
branch
2 times, most recently
from
2871c85 to
546362c
Compare
This improve on image size + delete source code from the container + delete latest image download + use bash as a default shell
Use parsa/qflex, as a more official name
Final image is around ~250MB + use python from ubuntu sources (3.12) + don't mess with pip + fix typo that broke everything
Better not use it
branylagaffe
force-pushed
the
feature/docker-container
branch
from
0a88643 to
63db226
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.