Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test errors and warnings #164

Merged
merged 2 commits into from
Nov 15, 2020
Merged

Fix test errors and warnings #164

merged 2 commits into from
Nov 15, 2020

Conversation

parroty
Copy link
Owner

@parroty parroty commented Nov 15, 2020

Changes

1. Fix for occasional error due to different ordering of multiple headers.

  1) test remove blacklisted headers (ExVCR.RecorderHttpcTest)
     test/recorder_httpc_test.exs:116
     Assertion with == failed
     code:  assert headers == [{'server', 'Cowboy'}, {'content-length', '13'}]
     left:  [{'content-length', '13'}, {'server', 'Cowboy'}]
     right: [{'server', 'Cowboy'}, {'content-length', '13'}]
     stacktrace:
       test/recorder_httpc_test.exs:120: (test)

2. Fix for Kernel.to_char_list/1 deprecation warnings.

Generated exvcr app
warning: Kernel.to_char_list/1 is deprecated, use Kernel.to_charlist/1 instead
  test/adapter_httpc_test.exs:21: ExVCR.Adapter.HttpcTest."test passthrough works when CurrentRecorder has an initial state"/1

warning: Kernel.to_char_list/1 is deprecated, use Kernel.to_charlist/1 instead
  test/adapter_httpc_test.exs:28: ExVCR.Adapter.HttpcTest."test passthrough works after cassette has been used"/1

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 92.308% when pulling 7be7203 on fix-test-errors-and-warnings into 63d47e3 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 92.308% when pulling 7be7203 on fix-test-errors-and-warnings into 63d47e3 on master.

@parroty parroty merged commit 5e1223e into master Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants