Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CurrentRecorder initial state #163

Merged
merged 1 commit into from
Nov 15, 2020

Conversation

surik
Copy link
Contributor

@surik surik commented Nov 12, 2020

The initial state should be nil to properly bypass mock when no cassette is used.

See #159 (comment)

Initial state should be `nil` to properly bypass mock when no cassette
is used.

See parroty#159 (comment)
@coveralls
Copy link

coveralls commented Nov 12, 2020

Coverage Status

Coverage increased (+0.2%) to 92.491% when pulling cf9585a on surik:fix-ccurrent-recorder-initial-state into d757ad4 on parroty:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.308% when pulling cf9585a on surik:fix-ccurrent-recorder-initial-state into d757ad4 on parroty:master.

@parroty parroty merged commit 9ba2a73 into parroty:master Nov 15, 2020
@parroty
Copy link
Owner

parroty commented Nov 15, 2020

Thanks!

@parroty
Copy link
Owner

parroty commented Nov 15, 2020

@surik
Just one thing that following warning seems emitted during the build (though the code itself does not appear multiple times). Does it make sense to change _arg to _?

$ mix test
warning: the underscored variable "_arg" appears more than once in a match. This means the pattern will only match if all "_arg" bind to the same value. If this is the intended behaviour, please remove the leading underscore from the variable name, otherwise give the variables different names
  lib/exvcr/actor.ex:58: ExVCR.Actor.CurrentRecorder.start_link/1

warning: the underscored variable "_arg" is used after being set. A leading underscore indicates that the value of the variable should be ignored. If this is intended please rename the variable to remove the underscore
  lib/exvcr/actor.ex:58: ExVCR.Actor.CurrentRecorder.start_link/1

$ elixir -v
Erlang/OTP 23 [erts-11.0.3] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [hipe] [dtrace]

Elixir 1.11.2 (compiled with Erlang/OTP 23)

@surik
Copy link
Contributor Author

surik commented Nov 15, 2020

@parroty ah yes, this would make sense.

@parroty
Copy link
Owner

parroty commented Nov 16, 2020

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants