Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: ignore one line #219

Closed
samm81 opened this issue Apr 29, 2020 · 1 comment · Fixed by #301
Closed

feature request: ignore one line #219

samm81 opened this issue Apr 29, 2020 · 1 comment · Fixed by #301

Comments

@samm81
Copy link

samm81 commented Apr 29, 2020

Using phoenix, I find that many use statements get tagged as not tested eg use MyAppWeb, :view

It would be nice to have the ability to ignore just the next line, eg # coveralls-ignore-next-line

Otherwise my formatter ends up spacing out the comments so what could be two lines takes five:

# coveralls-ignore-start

use MyAppWeb, :view

# coveralls-ignore-stop

Just a small thing. Thank you for all your work on this project!
RKushnir added a commit to RKushnir/excoveralls that referenced this issue Feb 19, 2023
@RKushnir
Ignore single next line
8a0ec98 
Allows to ignore the coverage for the following line of code,
by putting a new type of comment `# coveralls-ignore-next-line`.

Ignoring a single line is a common use case, which currently can be done by wrapping the code
between the "start" and "stop" comments. If we can achieve the same with just one comment,
this produces less visual noise and leaves more space for the useful code.

Resolves parroty#219
@RKushnir RKushnir mentioned this issue Feb 19, 2023
Merged
@jenskdsgn
Copy link

👍

Thanks @RKushnir for the implementation, I'd love to see this getting merged :)

parroty pushed a commit that referenced this issue Mar 2, 2023
@RKushnir
Ignore single next line (#301)
dc10f97 
* Ignore single next line

Allows to ignore the coverage for the following line of code,
by putting a new type of comment `# coveralls-ignore-next-line`.

Ignoring a single line is a common use case, which currently can be done by wrapping the code
between the "start" and "stop" comments. If we can achieve the same with just one comment,
this produces less visual noise and leaves more space for the useful code.

Resolves #219

* Mention the new type of comment in the readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore single next line RKushnir/excoveralls
2 participants
@samm81 @jenskdsgn