Search bar #537
Merged
Search bar #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid to need to do compose up at each code change
only on content & case sensitive
setting watch parameters to set rebuild after one second
remains subtype filtering remains automatic filter
add in phase 1
DavidRobertAnsart
requested changes
Feb 20, 2023
the button is active even if the class has not added any mimics
classes can visualize their mimic games
remove functions & const in 2 new files
change function filterActivityByTerm in FilterActivities
nodemon.json
Outdated
| "ignore": ["**/*.test.ts", "**/*.spec.ts", ".git", "node_modules", "src"], | ||
| "ignore": ["**/*.test.ts", "**/*.spec.ts", ".git", "node_modules"], |
There was a problem hiding this comment.
Can you add back "src" ?
There was a problem hiding this comment.
done, do I put my branch on staging or merge directly on master?
There was a problem hiding this comment.
There was a problem hiding this comment.
On master directly. Then the search-bar will automatically be deployed on prod.
DavidRobertAnsart
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ajout de la barre de recherche par terme.
En conservant les autres filtres et en ajoutant la recherche sur les subType des activités qui en ont.
Changes
Test