Vil 616 #1009
Closed
Vil 616 #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| public head(options: RouteOptions, handler: RequestHandler): void { | ||
| this.router.head(options.path, handleErrors(authenticate(options.userType)), handleErrors(handler)); |
Check failure
Code scanning / CodeQL
Missing rate limiting High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 1 month ago
To fix the problem, we need to introduce rate limiting to the routes in the Controller class. The best way to do this is by using the express-rate-limit package, which allows us to easily set up rate limiting middleware. We will create a rate limiter and apply it to all routes defined in the Controller class.
- Install the
express-rate-limitpackage. - Import the
express-rate-limitpackage in thecontroller.tsfile. - Create a rate limiter with a reasonable configuration (e.g., 100 requests per 15 minutes).
- Apply the rate limiter to all routes in the
Controllerclass.
Suggested changeset
1
server/controllers/controller.ts
| @@ -4,3 +4,4 @@ | ||
| import multer from 'multer'; | ||
| import path from 'path'; | ||
| import path from 'path'; | ||
| import rateLimit from 'express-rate-limit'; | ||
|
|
||
| @@ -23,9 +24,14 @@ | ||
|
|
||
| constructor(name: string) { | ||
| this.router = Router({ mergeParams: true }); | ||
| this.name = name; | ||
| } | ||
| private rateLimiter = rateLimit({ | ||
| windowMs: 15 * 60 * 1000, // 15 minutes | ||
| max: 100, // limit each IP to 100 requests per windowMs | ||
| }); | ||
|
|
||
| constructor(name: string) { | ||
| this.router = Router({ mergeParams: true }); | ||
| this.name = name; | ||
| } | ||
|
|
||
| public get(options: RouteOptions, handler: RequestHandler): void { | ||
| this.router.get(options.path, handleErrors(authenticate(options.userType)), handleErrors(handler)); | ||
| this.router.get(options.path, this.rateLimiter, handleErrors(authenticate(options.userType)), handleErrors(handler)); | ||
| } | ||
| @@ -33,3 +39,3 @@ | ||
| public head(options: RouteOptions, handler: RequestHandler): void { | ||
| this.router.head(options.path, handleErrors(authenticate(options.userType)), handleErrors(handler)); | ||
| this.router.head(options.path, this.rateLimiter, handleErrors(authenticate(options.userType)), handleErrors(handler)); | ||
| } | ||
| @@ -37,3 +43,3 @@ | ||
| public post(options: RouteOptions, handler: RequestHandler): void { | ||
| this.router.post(options.path, handleErrors(authenticate(options.userType)), handleErrors(handler)); | ||
| this.router.post(options.path, this.rateLimiter, handleErrors(authenticate(options.userType)), handleErrors(handler)); | ||
| } | ||
| @@ -41,3 +47,3 @@ | ||
| public put(options: RouteOptions, handler: RequestHandler): void { | ||
| this.router.put(options.path, handleErrors(authenticate(options.userType)), handleErrors(handler)); | ||
| this.router.put(options.path, this.rateLimiter, handleErrors(authenticate(options.userType)), handleErrors(handler)); | ||
| } | ||
| @@ -45,3 +51,3 @@ | ||
| public delete(options: RouteOptions, handler: RequestHandler): void { | ||
| this.router.delete(options.path, handleErrors(authenticate(options.userType)), handleErrors(handler)); | ||
| this.router.delete(options.path, this.rateLimiter, handleErrors(authenticate(options.userType)), handleErrors(handler)); | ||
| } | ||
| @@ -52,3 +58,4 @@ | ||
| options.path, | ||
| this.uploadVideoMiddleware.single(options.multerFieldName), | ||
| this.rateLimiter, | ||
| this.uploadVideoMiddleware.single(options.multerFieldName), | ||
| handleErrors(async (req, res, next) => { | ||
| @@ -69,3 +76,4 @@ | ||
| options.path, | ||
| this.uploadMiddleware.single(options.multerFieldName), | ||
| this.rateLimiter, | ||
| this.uploadMiddleware.single(options.multerFieldName), | ||
| handleErrors(authenticate(options.userType)), |
Copilot is powered by AI and may make mistakes. Always verify output.
| const filePath = req.file?.path; | ||
| if (filePath) { | ||
| res.on('finish', () => { | ||
| fs.remove(filePath).catch(); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 1 month ago
To fix the problem, we need to ensure that the filePath is validated before it is used in the fs.remove function. We can achieve this by normalizing the path using path.resolve and ensuring it is within a designated safe directory. This will prevent directory traversal attacks by removing any .. segments and ensuring the path is within the intended directory.
- Normalize the
filePathusingpath.resolve. - Check that the normalized path starts with the designated safe directory.
- If the path is valid, proceed with the file removal; otherwise, handle the error appropriately.
Suggested changeset
1
server/controllers/controller.ts
| @@ -55,8 +55,14 @@ | ||
| // clean up the file after the request is handled | ||
| const filePath = req.file?.path; | ||
| if (filePath) { | ||
| res.on('finish', () => { | ||
| fs.remove(filePath).catch(); | ||
| }); | ||
| } | ||
| const filePath = req.file?.path; | ||
| if (filePath) { | ||
| const safeDir = path.resolve(__dirname, '../fileUpload/videos'); | ||
| const resolvedPath = path.resolve(filePath); | ||
| if (resolvedPath.startsWith(safeDir)) { | ||
| res.on('finish', () => { | ||
| fs.remove(resolvedPath).catch(); | ||
| }); | ||
| } else { | ||
| console.error('Invalid file path:', resolvedPath); | ||
| } | ||
| } | ||
| next(); |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Enable filtering on a given phase for a given village.
Changes
Created a
phaseHistoryentity to track the starting and ending dates of phases for all villages.Created a phase filter on the statistics dashboard.
Made sure that teachers cannot rollback on a past phase.
Test
When you're logged in as a teacher, create a new student and note what is the active phase.
Using the phase filter, you should see the newly created student on the statistics dashboard when you're logged in as an administrator. Note that the table is displaying all data, whereas the purple cards display data by phases.