Quix fixes on fk and ts enum use

parlemonde · Nov 21, 2024 · 8511ef8 · 8511ef8
1 parent ea92e72
commit 8511ef8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/server/migrations/1731486908522-AddPhaseHistory.ts b/server/migrations/1731486908522-AddPhaseHistory.ts
@@ -74,7 +74,7 @@ export class AddPhaseHistory1731486908522 implements MigrationInterface {
   public async down(queryRunner: QueryRunner): Promise<void> {
     const table = await queryRunner.getTable('phase_history');
     if (table) {
-      const foreignKey = table.foreignKeys.find((fk) => fk.columnNames.indexOf('questionId') !== -1);
+      const foreignKey = table.foreignKeys.find((fk) => fk.columnNames.indexOf('villageId') !== -1);
       if (foreignKey) {
         await queryRunner.dropForeignKey('phase_history', foreignKey);
         await queryRunner.dropIndex('phase_history', 'IDX_PHASE_HISTORY');

diff --git a/src/components/admin/manage/settings/SavePhasesModal.tsx b/src/components/admin/manage/settings/SavePhasesModal.tsx
@@ -5,7 +5,7 @@ import { softDeletePhaseHistory } from 'src/api/phaseHistory/phaseHistory.delete
 import { postPhaseHistory } from 'src/api/phaseHistory/phaseHistory.post';
 import { useUpdateVillages } from 'src/api/villages/villages.put';
 import { Modal } from 'src/components/Modal';
-import type { VillagePhase } from 'types/village.type';
+import { VillagePhase } from 'types/village.type';
 
 interface SavePhasesModalProps {
   villagesToUpdate: { [villageId: number]: VillagePhase };
@@ -22,7 +22,7 @@ export function SavePhasesModal({ villagesToUpdate, isModalOpen, setIsModalOpen
     const promises = [];
     for (const key in villagesToUpdate) {
       const villageId: number = +key;
-      const updatedPhase = Math.min(villagesToUpdate[villageId], 3);
+      const updatedPhase = Math.min(villagesToUpdate[villageId], VillagePhase.IMAGINE);
       promises.push(
         updateVillages.mutateAsync({
           id: villageId,