This repository has been archived by the owner on Jan 18, 2023. It is now read-only.
using ls-remote instead of rev-parse to fetch revision #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def revision | ||
| @revision ||= `git rev-parse #{branch}`.chomp | ||
| @revision ||= `git ls-remote #{repository} #{branch}`.chomp |
There was a problem hiding this comment.
When I run this locally, I get soemthing like:
aa04140db6643ac65152cba813085815dfeb1141 refs/heads/master
It looks like this will need more modification! .split(" ").first
| @@ -91,8 +91,12 @@ def destination | |||
| fetch(:slack_destination, stage) | |||
| end | |||
|
|
|||
| def repository | |||
| fetch(:repository, 'origin') | |||
There was a problem hiding this comment.
origin is a remote, not a repository. what's your reasoning for using :repository here?
There was a problem hiding this comment.
It's my understanding (might be completely wrong) that :repository would be the capistrano's config for the remote's url?
There was a problem hiding this comment.
that's true! just making sure we clarified that :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #18