Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zndsl: support multiple networks #792

Closed
wants to merge 4 commits into from

Conversation

serban300
Copy link
Contributor

Just a draft implementation to showcase what we would need for #788

Might be missing some corner cases and might need some polishing

@wirednkod
Copy link
Contributor

Thank you @serban300 for this. I have "cloned" it and added some more lines (see #796 ) to fix the breaking CIs and lints. Still though the tests are not working.
I think it is a great idea in order to make the CLI work, to use instances of the orchestrator in order to run each network. You can either continue woring on my PR or copy/paste the changes I made in order to make yours work, and we can continue from there.

@serban300
Copy link
Contributor Author

@wirednkod Thank you for the fixes and the suggestion. I will try to implement it and fix the remaining CI failures.

@wirednkod
Copy link
Contributor

@wirednkod Thank you for the fixes and the suggestion. I will try to implement it and fix the remaining CI failures.

As mentioned in my previous comment: I think it is better to use instances of the orchestrator in order to run each network.

Just FYI I will try to put together this kind of approach in a different PR - in order to wrap my mind around your suggestion. Again thank you for the suggestion - it rings as a great idea.

@serban300
Copy link
Contributor Author

@wirednkod I didn't get to experiment with different instances of the orchestrator yet. I was trying to understand the CI failures first, and I think they occur because the zombie executable probably uses a version of parser-wrapper which is published from the latest main branch and not from this PR. Do you have a process for handling this kind of situations, where there is a change in the parser ? I didn't find anything in the documentation. This PR would need to use a locally compiled version of @zombienet/dsl-parser-wrapper.

@serban300
Copy link
Contributor Author

Closing in favor of #796

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants