Fixes clearAuthorities in chainspec when staking genesis is defined
#1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpestana
commented
Jan 30, 2024
| if (runtimeConfig?.staking) { | ||
| stakingBond = BigInt(runtimeConfig.staking.stakers[0][2]); |
There was a problem hiding this comment.
if the staking genesis is set but with an empty vec of stakers (which is totally OK), accessing stakers[0][2] would panic.
wirednkod
approved these changes
Jan 31, 2024
pepoviola
reviewed
Feb 1, 2024
Comment on lines
79
to
83
| stakingBond = BigInt(0); | ||
| for (const staker in runtimeConfig.staking.stakers) { | ||
| stakingBond += BigInt(runtimeConfig.staking.stakers[staker][2]); | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| stakingBond = BigInt(0); | |
| for (const staker in runtimeConfig.staking.stakers) { | |
| stakingBond += BigInt(runtimeConfig.staking.stakers[staker][2]); | |
| } | |
| if ( runtimeConfig.staking.stakers[0] ) stakingBond = BigInt(runtimeConfig.staking.stakers[0][2]); |
Hi @gpestana, in the current code we only use the value of the first staker for adding the nodes later (without add them). Something like this should work and we can change the first if condition to make the code more clean.
Thx!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
clearAuthoritiesoperation in chainspec when staking genesis is defined. I'm not 100% sure if the fix is correct, but at least is does not break when the staking pallet has some genesis configs defined as before.